Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-10797 - Fixed JSDoc issues #1762

Merged
merged 5 commits into from
Dec 17, 2024
Merged

WRR-10797 - Fixed JSDoc issues #1762

merged 5 commits into from
Dec 17, 2024

Conversation

daniel-stoian-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

JSDocs had wrong param names or types or unused params

Resolution

Fixed JSDocs param names or types or unused params

Additional Considerations

Links

WRR-10797

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (ec5e856) to head (f31eeaa).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1762   +/-   ##
========================================
  Coverage    80.90%   80.90%           
========================================
  Files          148      148           
  Lines         6677     6677           
  Branches      1989     1989           
========================================
  Hits          5402     5402           
  Misses         968      968           
  Partials       307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@seunghoh seunghoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave some question

DatePicker/DatePicker.js Outdated Show resolved Hide resolved
TimePicker/TimePicker.js Outdated Show resolved Hide resolved
DatePicker/DatePicker.js Outdated Show resolved Hide resolved
TimePicker/TimePicker.js Outdated Show resolved Hide resolved
@seunghoh seunghoh merged commit a76e348 into develop Dec 17, 2024
7 checks passed
@seunghoh seunghoh deleted the feature/WRR-10797-jsdoc branch December 17, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants