Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-10797 - Fixed JSDoc issues #1762

Merged
merged 5 commits into from
Dec 17, 2024
Merged

WRR-10797 - Fixed JSDoc issues #1762

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95568b0
Fixed JSDoc problems
daniel-stoian-lgp Dec 3, 2024
527e993
dummy commit
daniel-stoian-lgp Dec 3, 2024
5fea316
revert dummy commit
daniel-stoian-lgp Dec 3, 2024
2095e5a
Merge remote-tracking branch 'origin/develop' into feature/WRR-10797-…
daniel-stoian-lgp Dec 17, 2024
f31eeaa
code review fixes
daniel-stoian-lgp Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DatePicker/DatePicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ const DatePicker = Pure(
* @function
* @memberof sandstone/DatePicker
* @param {Date} date `Date` to convert
* @returns {String?} Converted date or `null` if `date` is invalid
* @returns {String|Null} Converted date or `null` if `date` is invalid
daniel-stoian-lgp marked this conversation as resolved.
Show resolved Hide resolved
seunghoh marked this conversation as resolved.
Show resolved Hide resolved
*/
const dateToLocaleString = (date) => {
if (!date) {
Expand Down
2 changes: 1 addition & 1 deletion TimePicker/TimePicker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ const TimePicker = Pure(
* @function
* @memberof sandstone/TimePicker
* @param {Date} time `Date` to convert
* @returns {String?} Converted date or `null` if `date` is invalid
* @returns {String|Null} Converted date or `null` if `date` is invalid
daniel-stoian-lgp marked this conversation as resolved.
Show resolved Hide resolved
daniel-stoian-lgp marked this conversation as resolved.
Show resolved Hide resolved
*/
const timeToLocaleString = (time) => {
if (!time) {
Expand Down
5 changes: 0 additions & 5 deletions TooltipDecorator/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,13 +156,8 @@ const calcOverflow = function (tooltipNode, clientNode, tooltipDirection, edgeKe
*
* @method
* @memberof sandstone/TooltipDecorator
* @param {Object} tooltipNode The `getBoundingClientRect` values for tooltip node
* @param {Object} clientNode The `getBoundingClientRect` values for client node
* @param {String} arrowAnchor Anchor position from `adjustAnchor`
* @param {String} tooltipDirection Direction of tooltip
* @param {Number} tooltipHeight Tooltip height
* @param {Object} overflow Tooltip's calculated overflow from `calcOverflow`
* @param {Boolean} rtl RTL mode
* @returns {Object} Tooltip top and left position
* @private
*/
Expand Down
2 changes: 0 additions & 2 deletions internal/validators/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
*
* @function
* @param {String} msg Event name
* @param {Function} fn Event handler
* @param {Node} [target=`document`] Event listener target
*
* @returns {undefined}
* @memberof sandstone/internal/validators
Expand Down
Loading