Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erronous pool timeout case #681

Closed
wants to merge 3 commits into from

Conversation

tomchristie
Copy link
Member

Refs #550.

Fixes an issue where a pool timeout can occur, even though a request has an assigned connection.

It's not clear to me if this is a complete resolution, or if something more substantial (see #653) is actually required.
But either way around I think this resolves an edge case for pool timeout: 0 cases.

Needs a test case.

@tomchristie tomchristie mentioned this pull request May 10, 2023
@nihilSup
Copy link

@tomchristie can you use two tests from #653? test_pool_under_load and test_pool_timeout_connection_cleanup to be more specific. Maybe I could add them myself but I don't know how

@tomchristie tomchristie marked this pull request as ready for review May 17, 2023 13:18
@tomchristie tomchristie mentioned this pull request May 17, 2023
3 tasks
@tomchristie
Copy link
Member Author

I've revised this in #688.
Added failing test cases first in the first commit, then resolved them in the second.

@tomchristie tomchristie deleted the fix-erronous-pool-timeout-case branch May 17, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants