Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pool timeout edge-case. #688

Merged
merged 3 commits into from
May 17, 2023

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented May 17, 2023

Second attempt at #681, with tests.

  • Add tests.
  • Fix implementation.
  • Update CHANGELOG.

Refs #550 (Possible that it resolves it, unclear?)

@tomchristie tomchristie changed the title Add tests for pool timeout zero Add tests for pool timeout zero. May 17, 2023
@tomchristie tomchristie added the bug Something isn't working label May 17, 2023
@tomchristie tomchristie changed the title Add tests for pool timeout zero. Fix pool timeout edge-case. May 17, 2023
@tomchristie tomchristie requested a review from Pliner May 17, 2023 13:48
@tomchristie
Copy link
Member Author

Right, we might as well also get this into the upcoming 0.17.1 release.

@tomchristie tomchristie requested a review from a team May 17, 2023 13:51
@tomchristie tomchristie mentioned this pull request May 17, 2023
@tomchristie tomchristie merged commit c353ce2 into master May 17, 2023
@tomchristie tomchristie deleted the fix-connection-pool-timeout-zero-behaviour branch May 17, 2023 15:11
bdraco added a commit to home-assistant/core that referenced this pull request Jun 13, 2023
changelog: encode/httpcore@0.17.0...0.17.2

encode/httpcore#688 is likely the cause of some onvif issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants