Corrected --proxy-headers client ip/host when using a unix socket #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalp
reviewed
May 9, 2020
rafalp
reviewed
May 9, 2020
|
Also let's go with more descriptive Pull Request names, please. 😃 References to issues ought to go in the description, eg "Refs #634" rather than in the PR name. |
euri10
changed the title
euri10
changed the title
done ! no excuses :) |
|
Cool, it's using the new CI with windows fine 😁 |
|
sorry I cant squash and merge, got the same issue where it wants to have tests made before the CI change to pass. |
euri10
added a commit
to euri10/uvicorn
that referenced
this pull request
Jul 29, 2020
…cket (encode#636)" This reverts commit a796e1d
stefanw
added a commit
to stefanw/uvicorn
that referenced
this pull request
Jul 30, 2020
…cket (encode#636)" This reverts commit a796e1d.
This was referenced Jul 30, 2020
euri10
added a commit
that referenced
this pull request
Jul 31, 2020
…socket (#729) * Revert "Corrected --proxy-headers client ip/host when using a unix socket (#636)" This reverts commit a796e1d * Distinguish case fd/unix socket to return correctly client * Handle windows case * Added test for AF_UNIX socket type Modified MockSocket peername to pass tuples instead of list because socket.getpeername() and socket.getsockname() return tuples * Black * Removed test, black works locally but not in CI.... * Same deal on the server side of things * Test on AF_UNIX only if it is in socket * Simpler handling * Removed debug leftovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #634