Get the request.client under case uvicorn is run with a fd or a unix socket

[euri10]

should solve #727 and still give the correct info that #634 wanted

[florimondmanca]

My understanding is that in some cases the socket_info.getpeername() may return a string containing the path to the Unix socket, and we need to ignore that case, correct?

I'm curious - in what cases, when bound to a Unix socket, can it return a (host, port) tuple? Isn't binding to a Unix socket not done via a host/port by definition? Had we confirmed that #636 did fix #634?

[florimondmanca]

I think I'd do something like this, to simplify:

HAS_AF_UNIX = hasattr(socket, "AF_UNIX")

def get_remote_addr(transport):
    ...

        if family in (socket.AF_INET, socket.AF_INET6) or (
            HAS_AF_UNIX and family == socket.AF_UNIX and isinstance(family, tuple)
        ):
            return (str(info[0]), int(info[1]))

        return None

[tomchristie]

Could we just change the whole block to...

return (str(info[0]), int(info[1])) if isinstance(info, tuple) else None

[euri10]

I did it that way, way simpler,
Just note that I kept in get_remote_addr the try except introduced it seems in #495

[florimondmanca]

We might want to simply revert #636. It's not clear to me that it did fix anything, given how according to https://docs.python.org/3/library/socket.html there is no host/port information available when binding to a Unix socket. I think #634 was a non-issue ("yes there's no host/port because your server is not bound to a TCP socket").

[euri10]

My understanding is that in some cases the socket_info.getpeername() may return a string containing the path to the Unix socket, and we need to ignore that case, correct?

correct

I'm curious - in what cases, when bound to a Unix socket, can it return a (host, port) tuple? Isn't binding to a Unix socket not done via a host/port by definition? Had we confirmed that #636 did fix #634?

if you run uvicorn with supervisord -n using

[supervisord]

[fcgi-program:uvicorn]
socket=tcp://localhost:8000
command=venv/bin/uvicorn --fd 0 app:app
process_name=uvicorn-%(process_num)d
stdout_logfile=/dev/stdout
stdout_logfile_maxbytes=0

then you end up having socket_info to what I left in comments <uvloop.PseudoSocket fd=13, family=AddressFamily.AF_UNIX, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 8000), raddr=('127.0.0.1', 38634)>

[florimondmanca]

I see, so in that case Supervisord's FastCGI support makes the TCP socket available at fd=0, which is a Unix socket, and for some reason the original TCP host:port info is made available on the Unix socket object too? (I'm definitely no Unix networking wizard, so trying to get my head around this…)

[bukowa]

I merged this patch into integration test with nginx - it works https://github.com/bukforks/uvicorn/tree/django_nginx
#734

[florimondmanca]

I guess we can merge this and get it along for 0.11.8. 👍 #731