T35541 block code in bottom panel #117
Conversation
|
This is technically ready to review, but I'm marking it as a draft because we should wait for additional feedback related to the design. The big change here is removing the block code editor as a main panel, and instead adding it to the bottom bar:
As before, it appears automatically if a The editor is very, very busy here, but fortunately Godot does have a button on the bottom right corner to expand the bottom panel, which results in a similar experience to what we have right now:
With Block Code in the bottom panel, we gain another neat trick: we can be cleverer about empty states. In particular, since we are working in the same context as the rest of the scene, the Block Code editor can provide helper text if the scene is empty, and it can guide the user to creating a
… or override block code for a node, if the node came with its own
|
dylanmccall
force-pushed
the
T35541-block-code-in-bottom-panel
branch
2 times, most recently
from
73d8e14
to
5264ba3
Compare
|
@dylanmccall this is a huge improvement! I'm not sure about displaying the Block Code editor for if the parent node with BlockCodeNode attached is selected in the Scene Tree. Here I tried the branch adding blocks to AnimationPlayer and TileMap. When I click these nodes, sometimes I get their corresponding editors (Animation bottom dock, TileMap bottom dock) and sometimes the blocks editor. |
Hm, okay, I was wondering if that might cause conflicts. In 0026aab I changed this so the editor only opens itself if the user chooses a Block Code node explicitly, which should solve the problem there and is better in line with how the Animation and Tile Map panels behave. |
|
I just tested this out on my end. I like the behavior of opening the Block Code panel when a BlockCode node is selected, but just switching the script (not opening the panel) when a parent to a BlockCode node is selected. I think I like this layout better - on my small laptop it is a few extra clicks to get it looking organized, but on larger screens it's way better. It would be good to get some feedback from the learning team to see what they think about the new layout. I wonder if they think being able to see the scene/properties of nodes is worth the layout change. |
This new bottom panel control will appear whenever a BlockCode node is present in the scene. https://phabricator.endlessm.com/T35541
This now works as expected. https://phabricator.endlessm.com/T35541
To improve the experience when using block coding side by side with the 2D or 3D canvas, the Block Code panel will display block code associated with the selected node. https://phabricator.endlessm.com/T35541
When editing a block code resource in the context of a scene, make sure we are saving the result in the same scene by creating a new copy. This improves the workflow when editing BlockCode nodes from instantiated child scenes: a user is unlikely to expect a change with the Block Code editor in one scene to modify a different scene file. https://phabricator.endlessm.com/T35541
This reorganizes the empty state widgets in BlockCanvas, adding a new set of actions when the user selects a node which contains block code, but the block code can't be edited. This commit also includes changes to better handle when a BlockCode node is inside a node from a different scene but with editable children. https://phabricator.endlessm.com/T35541
We want the buttons in the block canvas empty state to have a visible outline against the default background. We can achieve this by using the "InspectorActionButton" type variation, which is used for a similar situation in the Godot editor's built in Inspector panel. https://phabricator.endlessm.com/T35541
dylanmccall
force-pushed
the
T35541-block-code-in-bottom-panel
branch
from
0026aab
to
875a7c8
Compare
In order for a node to be selected on the 2D canvas while its associated BlockCode is being edited, automatically select the current BlockCode node's parent. This requires some changes in BlockCodePlugin to deal with cases when multiple nodes are selected in the Scene panel and in the Inspector panel. https://phabricator.endlessm.com/T35541
With the change to always select a BlockCode node's parent along with the BlockCode node itself, it is difficult to select just a BlockCode node to delete it. To work around this, add a button to delete the current block code node. https://phabricator.endlessm.com/T35541
dylanmccall
force-pushed
the
T35541-block-code-in-bottom-panel
branch
from
85adf70
to
ed99a84
Compare
|
This got a +1 from @jofilizola. I added a couple bits based on her feedback:
Happy to merge this any time :) |
There was a problem hiding this comment.
Awesome stuff! Once I get my zooming and panning merged I think it will go really great with this.
One thing I noticed is that when selecting a BlockCode node there is a significant amount of lag on my end, presumably from loading all the blocks in (not the fault of this PR at all). We should figure out what's causing that.
https://phabricator.endlessm.com/T35541