Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T35541 block code in bottom panel #117

Merged
merged 12 commits into from
Jul 9, 2024
Merged

Commits on Jul 8, 2024

  1. Move Block Code editor to the bottom panel

    This new bottom panel control will appear whenever a BlockCode node is
    present in the scene.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    63d405a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e2af87 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2c2db15 View commit details
    Browse the repository at this point in the history
  4. Show block code for a node with a BlockCode node as a child

    To improve the experience when using block coding side by side with the
    2D or 3D canvas, the Block Code panel will display block code associated
    with the selected node.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4593d1f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea31273 View commit details
    Browse the repository at this point in the history
  6. Duplicate instead of modifying block code resources from other scenes

    When editing a block code resource in the context of a scene, make sure
    we are saving the result in the same scene by creating a new copy. This
    improves the workflow when editing BlockCode nodes from instantiated
    child scenes: a user is unlikely to expect a change with the Block Code
    editor in one scene to modify a different scene file.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e0a4208 View commit details
    Browse the repository at this point in the history
  7. Add a feature to override BlockCode from a child scene

    This reorganizes the empty state widgets in BlockCanvas, adding a new
    set of actions when the user selects a node which contains block code,
    but the block code can't be edited. This commit also includes changes
    to better handle when a BlockCode node is inside a node from a different
    scene but with editable children.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a3b6898 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    de84895 View commit details
    Browse the repository at this point in the history
  9. Add InspectorActionButton type variation for block canvas buttons

    We want the buttons in the block canvas empty state to have a visible
    outline against the default background. We can achieve this by using the
    "InspectorActionButton" type variation, which is used for a similar
    situation in the Godot editor's built in Inspector panel.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    875a7c8 View commit details
    Browse the repository at this point in the history
  10. Select parent node when a BlockCode is selected

    In order for a node to be selected on the 2D canvas while its associated
    BlockCode is being edited, automatically select the current BlockCode
    node's parent. This requires some changes in BlockCodePlugin to deal
    with cases when multiple nodes are selected in the Scene panel and in
    the Inspector panel.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    a808f67 View commit details
    Browse the repository at this point in the history
  11. Add a button to delete the current BlockCode node

    With the change to always select a BlockCode node's parent along with
    the BlockCode node itself, it is difficult to select just a BlockCode
    node to delete it. To work around this, add a button to delete the
    current block code node.
    
    https://phabricator.endlessm.com/T35541
    dylanmccall committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    8874010 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    ed99a84 View commit details
    Browse the repository at this point in the history