Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports Ruby or JRuby version 1.9.x syntax. #3

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Supports Ruby or JRuby version 1.9.x syntax. #3

merged 1 commit into from
Feb 9, 2016

Conversation

mosuka
Copy link
Contributor

@mosuka mosuka commented Jan 31, 2016

Logstash is using Ruby or JRuby version 1.9.x internally. Supports the syntax of 1.9.x so that rsolr-cloud can be used in the Logstash.

@mosuka mosuka changed the title Supports Ruby or JRuby version 1.9.x Syntax. Supports Ruby or JRuby version 1.9.x syntax. Jan 31, 2016
@mosuka
Copy link
Contributor Author

mosuka commented Feb 8, 2016

Hi,
I would like to supports the syntax of 1.9.x so rsolr-cloud can be used in the Logstash.
Have you considered about my proposal? If you have any concerns or questions please free to ask me anytime.
Thanks, :)

kmrshntr added a commit that referenced this pull request Feb 9, 2016
Supports Ruby or JRuby version 1.9.x syntax.
@kmrshntr kmrshntr merged commit 43f81a9 into enigmo:master Feb 9, 2016
@kmrshntr
Copy link
Member

kmrshntr commented Feb 9, 2016

There is no problem because it doesn't make any effect to the interface of public methods. This change will release soon. Thank you.
@mosuka By the way, what kind of interesting thing does Logstash make with this gem? I'm just curious.

@mosuka
Copy link
Contributor Author

mosuka commented Feb 9, 2016

Thank you for commit. I'm looking forward to new version. When it released, my project will be referred new one.

https://github.com/mosuka/logstash-output-solr
https://github.com/mosuka/fluent-plugin-output-solr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants