This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
[SDK 82] Improved builder usages #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 27, 2021 16:44
- Explicitly deleted copy-constructors from client and schema classes - Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function
- PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer
- Explicitly deleted copy-constructor from `PusherEventService` - Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
…vice` implementation
Favorlock
approved these changes
Oct 12, 2021
BishopJohnson
pushed a commit
that referenced
this pull request
Oct 31, 2021
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Nov 5, 2021
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Nov 24, 2021
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Jan 19, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
May 5, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
May 21, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
May 22, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
pushed a commit
that referenced
this pull request
Jul 6, 2022
* Improved builder usage for `PlayerClient` * Improved builder usage for `ProjectClient` * Improved builder usage for `PusherEventService` * Improved builder usage for `HttpRequest` * Improved builder usage for `HttpResponse` * Added move-constructors to client and schema classes * Explicitly deleted copy-constructors from client and schema classes * Builders for `ProjectClient` and `PlayerClient` no longer return a unique-pointer from their `build()` member-function * PusherClient now only holds a reference to the websocket client * PusherEventService::Impl class now holds a unique-pointer for its websocket client instead of a shared-pointer * Added move-constructor to `PusherEventService` * Explicitly deleted copy-constructor from `PusherEventService` * Builder for `PusherEventService` no longer returns a unique-pointer from its `build()` member-function
BishopJohnson
added a commit
that referenced
this pull request
Jul 18, 2022
* Improved builder usages (#22) * Using `static_cast` over `dynamic_cast` in fragment arguments (#24) * Null HTTP client check in middleware (#26) * Transition to pass-by-value (#29) * Logging utility restructure (#31) * HTTP restructure (#32) * Automatic reauthentication for `ProjectClient` (#34) * Reworked platform middleware (#41) * Replaced upper-snake-case in API with pascal case (#45) * Added JSON API and reworked serialization and deserialization (#46) * Renamed model and request classes (#47) * Refactored model classes to utilize Pimpl idiom (#48) * Improved `PusherEventService` implementation (#49) * Created static class `EnjinHosts` and moved host URIs into it (#50)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.