This repository has been archived by the owner on Jun 22, 2023. It is now read-only.
[SDK 215] Refactored model classes to utilize Pimpl idiom #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Favorlock
approved these changes
Jun 12, 2022
BishopJohnson
force-pushed
the
refactor/SDK-197/rename-model-classes
branch
from
7f01ace
to
49c7434
Compare
Base automatically changed from
refactor/SDK-197/rename-model-classes
to
v2/beta
June 13, 2022 10:17
BishopJohnson
force-pushed
the
refactor/SDK-215/pimpl-idiom-for-models
branch
from
0fc5a95
to
640ea75
Compare
BishopJohnson
added a commit
that referenced
this pull request
Jul 6, 2022
BishopJohnson
added a commit
that referenced
this pull request
Jul 18, 2022
* Improved builder usages (#22) * Using `static_cast` over `dynamic_cast` in fragment arguments (#24) * Null HTTP client check in middleware (#26) * Transition to pass-by-value (#29) * Logging utility restructure (#31) * HTTP restructure (#32) * Automatic reauthentication for `ProjectClient` (#34) * Reworked platform middleware (#41) * Replaced upper-snake-case in API with pascal case (#45) * Added JSON API and reworked serialization and deserialization (#46) * Renamed model and request classes (#47) * Refactored model classes to utilize Pimpl idiom (#48) * Improved `PusherEventService` implementation (#49) * Created static class `EnjinHosts` and moved host URIs into it (#50)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.