Add gateway support #136
Add gateway support #136
Conversation
rowanG077
force-pushed
the
master
branch
4 times, most recently
from
f7de4c0
to
923dc39
Compare
Also added UDPRawCore
|
I think the logic now is correct. I will test out whether it works in Hardware soon. |
|
|
||
| self.sync += masked_ip.eq(sink.ip_address & netmask) | ||
| self.sync += in_subnet.eq(masked_ip == netaddress) | ||
| self.sync += If(in_subnet, |
There was a problem hiding this comment.
@enjoy-digital Now having slept on it, I'm not actually sure this will work correctly. Essentially the IP address now needs to be stable for 3 clock cycles before the SEND_MAC_ADDRESS_REQUEST is reached. I don't know enough about packetizers and entire stack whether this is true. We have a single cycle for sure so I could shrink the pipeline.
|
@rowanG077 Thanks for the PR, I'll look at it. It's however integrating 3 different changes. Would you mind creating a PR per specific changes? This will ease review and merging progressively the different features. For the UDP Raw mode, it would probably be better to add a mode parameter to the defined UDP ports, where mode could be |
This is a simple method to add a static gateway + netmask.
TODO: Test in hardware if you can actually go over the internet with this.
I also added UDPRawCore in the generator.