Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty regions don't get resolved #6548

Closed
ashklianko opened this issue Jul 17, 2023 · 0 comments · Fixed by #6558
Closed

Empty regions don't get resolved #6548

ashklianko opened this issue Jul 17, 2023 · 0 comments · Fixed by #6558
Assignees
@ashklianko
Labels
Bug Something isn't working

Comments

@ashklianko
Copy link
Member

Current behavior is that regions resolving is forced since it is expected that content is being returned without empty regions, however this will make it possible that content is returned with or without empty regions.

-Update the code so it fetches regions only when required
@ashklianko ashklianko self-assigned this Jul 17, 2023
@ashklianko ashklianko added the Improvement Suggestion for improvement label Jul 17, 2023
ashklianko added a commit that referenced this issue Jul 18, 2023
@ashklianko
Make empty regions resolving independent of content api #6548
2020955
@ashklianko ashklianko linked a pull request Jul 18, 2023 that will close this issue
Make empty regions resolving independent of content api #6548 #6558
Merged
ashklianko added a commit that referenced this issue Jul 21, 2023
@ashklianko
Make empty regions resolving independent of content api #6548
08ac142
@alansemenov alansemenov added Bug Something isn't working and removed Improvement Suggestion for improvement labels Jul 21, 2023
@alansemenov alansemenov changed the title Make empty regions resolving independent of content api Empty regions don't get resolved Jul 21, 2023
alansemenov pushed a commit that referenced this issue Jul 21, 2023
@ashklianko @alansemenov
Make empty regions resolving independent of content api #6548
8eb569f
ashklianko added a commit that referenced this issue Jul 21, 2023
@ashklianko
Make empty regions resolving independent of content api #6548
a6ce100
ashklianko added a commit that referenced this issue Jul 21, 2023
@ashklianko
Make empty regions resolving independent of content api #6548
b8908ec
ashklianko added a commit that referenced this issue Jul 21, 2023
@ashklianko
Make empty regions resolving independent of content api #6548
3efc242
alansemenov pushed a commit that referenced this issue Jul 27, 2023
@ashklianko @alansemenov
Make empty regions resolving independent of content api #6548
09881e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make empty regions resolving independent of content api #6548 enonic/app-contentstudio
2 participants
@ashklianko @alansemenov