-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support resolution of empty regions in Content API #10209
Comments
ashklianko
changed the title
Rollback Page object resolving: inject empty regions to the page object when returning content
Page object resolving: introduce flag to resolve empty regions in Content API
Jul 17, 2023
ashklianko
added a commit
that referenced
this issue
Jul 18, 2023
…ct when returning content #10209 -Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is -Updated core-content classes to read config variable and build page object according to it -Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 18, 2023
…ct when returning content #10209 -Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is -Updated core-content classes to read config variable and build page object according to it -Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 18, 2023
…ct when returning content #10209 -Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is -Updated core-content classes to read config variable and build page object according to it -Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
changed the title
Page object resolving: introduce flag to resolve empty regions in Content API
Page resolving: add flag to resolve empty regions in Content API
Jul 19, 2023
ashklianko
added a commit
that referenced
this issue
Jul 19, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 20, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 20, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 20, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 20, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
ashklianko
added a commit
that referenced
this issue
Jul 20, 2023
- Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
rymsha
pushed a commit
that referenced
this issue
Jul 21, 2023
… (#10214) - Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api
rymsha
pushed a commit
that referenced
this issue
Jul 24, 2023
… (#10214) - Introduced xp.content config variable resolveEmptyRegions (set to 'false' by default) that allows to switch between previous content page resolving behavior that forces injection of all descriptor's regions into page/layout and new one where content's page object is returned as it is - Updated core-content classes to read config variable and build page object according to it - Updated portal-impl classes to read descriptor and inject empty regions into page if it is not being made by content api, and not to read and inject regions if it is done by content api (cherry picked from commit c4b556f)
alansemenov
changed the title
Page resolving: add flag to resolve empty regions in Content API
Support resolution of empty regions in Content API
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to @sigdestad customers rely on content api to return content object with injected empty regions. For that case we are going to introduce config flag resolveEmptyRegions that is set to false by default, and switching it to true will bring previous behavior when descriptors are being read and empty regions injected directly into content object returned by API.
The text was updated successfully, but these errors were encountered: