Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback Page object resolving: inject empty regions to the page obje… #10211

Closed
wants to merge 1 commit into from

Conversation

ashklianko
Copy link
Member

…ct when returning content #10209

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.07 ⚠️

Comparison is base (c1883c7) 84.34% compared to head (20d2d7e) 84.27%.

Additional details and impacted files
@@             Coverage Diff              @@
##               7.13   #10211      +/-   ##
============================================
- Coverage     84.34%   84.27%   -0.07%     
+ Complexity    19418    19357      -61     
============================================
  Files          2595     2595              
  Lines         67678    67691      +13     
  Branches       5390     5382       -8     
============================================
- Hits          57083    57048      -35     
- Misses         7982     8024      +42     
- Partials       2613     2619       +6     
Impacted Files Coverage Δ
.../xp/core/impl/content/ReprocessContentCommand.java 0.00% <0.00%> (ø)
.../impl/content/serializer/RegionDataSerializer.java 100.00% <ø> (ø)
...al/impl/handler/render/ComponentHandlerWorker.java 63.63% <0.00%> (-27.28%) ⬇️
...portal/impl/handler/render/PageResolverResult.java 100.00% <ø> (+11.11%) ⬆️
.../content/page/region/GetComponentByKeyCommand.java 77.77% <33.33%> (-15.08%) ⬇️
.../portal/impl/handler/render/PageHandlerWorker.java 73.17% <33.33%> (-4.33%) ⬇️
.../postprocess/instruction/ComponentInstruction.java 47.16% <73.33%> (-41.86%) ⬇️
...tent/serializer/LayoutComponentDataSerializer.java 84.61% <87.50%> (-7.70%) ⬇️
...nonic/xp/core/impl/content/ContentServiceImpl.java 77.92% <93.33%> (+0.28%) ⬆️
...ic/xp/core/impl/content/ContentNodeTranslator.java 91.66% <100.00%> (ø)
... and 17 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ashklianko ashklianko closed this Jul 18, 2023
@rymsha rymsha deleted the 7.13.1 branch July 24, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant