Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib-portal.getContent doesn't resolve page templates #10800

Closed
ComLock opened this issue Dec 10, 2024 · 1 comment · Fixed by #10807
Closed

lib-portal.getContent doesn't resolve page templates #10800

ComLock opened this issue Dec 10, 2024 · 1 comment · Fixed by #10807
Assignees
@ashklianko
Labels
Bug
Milestone
7.15.0

Comments

@ComLock
Copy link
Member

ComLock commented Dec 10, 2024 •
edited by rymsha
Loading

Does not work in site mapping controllers (and probably filters too)

But does work on normal page controllers
@ComLock ComLock added the Bug label Dec 10, 2024
@ComLock ComLock mentioned this issue Dec 10, 2024
Closed
@rymsha rymsha changed the title lib-portal.getContent doesn't resolve page templates in site mapping controllers (and probably filters too) lib-portal.getContent doesn't resolve page templates Dec 11, 2024
@rymsha rymsha added this to the 7.15.0 milestone Dec 11, 2024
@ashklianko
Copy link
Member

Confirm, MappingHandlerHelper.java doesn't resolve Page object as in for example PageHandlerWorker.java

@rymsha rymsha mentioned this issue Dec 13, 2024
Open
ashklianko added a commit that referenced this issue Dec 13, 2024
@ashklianko
lib-portal.getContent doesn't resolve page templates #10800
d199f10 
- Added Page resolving for the mappers, thus request get content with injected page/regions etc.
@ashklianko ashklianko linked a pull request Dec 13, 2024 that will close this issue
lib-portal.getContent doesn't resolve page templates #10800 #10807
Merged
ashklianko added a commit that referenced this issue Dec 13, 2024
@ashklianko
lib-portal.getContent doesn't resolve page templates #10800
aef3667
ashklianko added a commit that referenced this issue Dec 16, 2024
@ashklianko
lib-portal.getContent doesn't resolve page templates #10800
9c442ac
rymsha pushed a commit that referenced this issue Dec 16, 2024
@ashklianko @rymsha
lib-portal.getContent doesn't resolve page templates #10800
f71fde8
rymsha pushed a commit that referenced this issue Dec 16, 2024
@ashklianko @rymsha
lib-portal.getContent doesn't resolve page templates #10800
1f9f540 
(cherry picked from commit f71fde8)
@rymsha rymsha closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashklianko ashklianko

Labels
Bug
Projects
None yet
Milestone
7.15.0
Development

Successfully merging a pull request may close this issue.

lib-portal.getContent doesn't resolve page templates #10800 enonic/xp
4 participants
@ComLock @rymsha @ashklianko @anatol-sialitski