Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib-portal.getContent doesn't resolve page templates #10800 #10807

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ashklianko
Copy link
Member

  • Added Page resolving for the mappers, thus request get content with injected page/regions etc.

@ashklianko ashklianko requested a review from rymsha December 13, 2024 11:29
@ashklianko ashklianko linked an issue Dec 13, 2024 that may be closed by this pull request
@ashklianko ashklianko marked this pull request as draft December 13, 2024 11:37
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.51%. Comparing base (1856eb1) to head (aef3667).

Files with missing lines Patch % Lines
...tal/impl/handler/mapping/MappingHandlerHelper.java 92.85% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               7.15   #10807   +/-   ##
=========================================
  Coverage     84.51%   84.51%           
- Complexity    19626    19630    +4     
=========================================
  Files          2608     2608           
  Lines         68283    68295   +12     
  Branches       5434     5433    -1     
=========================================
+ Hits          57709    57720   +11     
  Misses         7937     7937           
- Partials       2637     2638    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashklianko ashklianko marked this pull request as ready for review December 13, 2024 18:23
@ashklianko
Copy link
Member Author

ashklianko commented Dec 13, 2024

One more question: should we resolve for all RenderMode(s) or for Edit/Live etc.?

@rymsha rymsha merged commit f71fde8 into 7.15 Dec 16, 2024
3 checks passed
@rymsha rymsha deleted the issue-10800 branch December 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib-portal.getContent doesn't resolve page templates
2 participants