Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-4226 merge 7.1 #240

Merged
merged 3 commits into from
Nov 14, 2022
Merged

ENG-4226 merge 7.1 #240

merged 3 commits into from
Nov 14, 2022

Conversation

alepintus
Copy link
Member

No description provided.

avdev4j and others added 3 commits October 5, 2022 16:16
@avdev4j
Copy link
Contributor

avdev4j commented Nov 14, 2022

hi @alepintus
please note there is something missing here: the version updating in the package.json file. I guess this branch has been created from the tag. Do you think we can update it nevertheless?

@avdev4j
Copy link
Contributor

avdev4j commented Nov 14, 2022

We can close this one since the PRs have been previously merged into both 7.1 branch and develop

@alepintus alepintus closed this Nov 14, 2022
@alepintus alepintus deleted the ENG-4226-merge-7.1 branch November 14, 2022 14:37
@alepintus alepintus restored the ENG-4226-merge-7.1 branch November 14, 2022 16:28
@alepintus alepintus reopened this Nov 14, 2022
@alepintus
Copy link
Member Author

alepintus commented Nov 14, 2022

Hi @avdev4j talking with @zonia3000, @antromeo and @cecchisandrone about this PR we were thinking to merge this commits to have the same history and to avoid to have these commits if we have to merge again from the release branch.
WDYT?

@avdev4j
Copy link
Contributor

avdev4j commented Nov 14, 2022

yes, this is true. let's do it. Next time maybe do one PR to develop then to the release branch so we'll have to do merge that kind of merge commits.
In this case, it's mostly because we did both the dev and the release in a short time frame.

@avdev4j avdev4j merged commit 4d4eeba into develop Nov 14, 2022
@alepintus alepintus deleted the ENG-4226-merge-7.1 branch November 15, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants