Cleans up generated code output. #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty involved PR in what it does. There is a decent amount of code changes but nothing to crazy. Here are the things the PR does removes duplicate imports removes unused imports puts declarations after imports instead of being mixed in with the imports formats most code that is over 80 characters on a single line 2 blank line before and after classes puts class docstrings as the first line in the class this way it can actually get set to a docstring fixes lack of triple double quotes not being used around class docstrings So in a nutshell it makes most of the generated code PEP8 compliant and it makes the generated code a whole hell of a lot easier on the 👀
|
pywinauto tests with this PR branch (just started): https://ci.appveyor.com/project/pywinauto/pywinauto-8b7t7/builds/42558727 One Python 3.6 line fails expectedly. The rest should pass. Hopefully. |
vasily-v-ryabov
approved these changes
Feb 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty involved PR in what it does. There is a decent amount of code changes but nothing to crazy. Here are the things the PR does
removes duplicate imports
removes unused imports
puts declarations after imports instead of being mixed in with the imports
formats most code that is over 80 characters on a single line
2 blank lines before and after classes
puts class docstrings as the first line in the class this way it can actually get set to
__doc__fixes lack of triple double quotes not being used around class docstrings
So in a nutshell it makes most of the generated code PEP8 compliant and it makes the generated code a whole hell of a lot easier on the 👀