Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I messed up rebasing #275 this is a new PR as a replacement for that. #281

Merged
merged 1 commit into from
Mar 2, 2022
Merged

I messed up rebasing #275 this is a new PR as a replacement for that. #281

merged 1 commit into from
Mar 2, 2022

Conversation

kdschlosser
Copy link
Contributor

@kdschlosser kdschlosser commented Feb 15, 2022 •
edited
Loading

see #275 for information about this PR

correction for commit description. It is not #279, it's #275 commit this is replacing

@kdschlosser kdschlosser changed the title I messed up rebasing #279 this is a new PR as a replacement for that. I messed up rebasing #275 this is a new PR as a replacement for that. Feb 15, 2022
@kdschlosser kdschlosser mentioned this pull request Feb 15, 2022
Closed
@vasily-v-ryabov vasily-v-ryabov merged commit 51ebf5b into enthought:master Mar 2, 2022
@kdschlosser kdschlosser deleted the net_code_generator_fix branch March 2, 2022 13:33
@vasily-v-ryabov
Copy link
Collaborator

I guess this PR has broken comtypes==1.1.12. This is confirmed in the comments under StackOverflow answer: https://stackoverflow.com/a/65467292/3648361
I removed comtypes==1.1.12 from PyPI for now, but master branch is not reverted yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasily-v-ryabov vasily-v-ryabov vasily-v-ryabov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdschlosser @vasily-v-ryabov