Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better (and more descriptive) loggings #30

Closed
yaronya opened this issue Jun 28, 2020 · 0 comments · Fixed by #62
Closed

Better (and more descriptive) loggings #30

yaronya opened this issue Jun 28, 2020 · 0 comments · Fixed by #62
Assignees
@shlomimatichin
Labels
enhancement New feature or request good first issue Good for newcomers P3

Comments

@yaronya
Copy link
Contributor

yaronya commented Jun 28, 2020 •
edited
Loading

Suggestions of some current terratag cli prints that are missing:

  1. Summary (Important) -
    We should have some summary of the terratag cli run like:
Processed: X
Tagged: X
  1. Eliminate out of context prints (Optional) -
    On the Resource taggable, processing... we should also log the resource type, in favor of easier debugging.
@yaronya yaronya added the enhancement New feature or request label Jun 28, 2020
@roni-frantchi roni-frantchi added the good first issue Good for newcomers label Jul 2, 2020
@yaronya yaronya changed the title Terratag should print a summary with tagged resources amount Better (and more descriptive) loggings Jul 4, 2020
@shlomimatichin shlomimatichin self-assigned this Oct 11, 2020
shlomimatichin added a commit to shlomimatichin/terratag that referenced this issue Oct 11, 2020
@shlomimatichin
Added more verbose logging, re issue env0#30
7de9980
@shlomimatichin shlomimatichin mentioned this issue Oct 12, 2020
Merged
shlomimatichin added a commit to shlomimatichin/terratag that referenced this issue Oct 13, 2020
@shlomimatichin
Added more verbose logging, re issue env0#30
0589994
roni-frantchi pushed a commit that referenced this issue Oct 16, 2020
@shlomimatichin
added -rename=false cli flag (#62)
383fed0 
* Added -verbose=true cli flag, [DEBUG] messages off by default

* added -rename=false cli flag

* Added more verbose logging, re issue #30

* filter debug messages from tfschema in non verbose mode

* removed tfschema fork (PR accepted)

* code review

* Updated README with optional CLI flags

* code review: refactor initLogFiltering function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomimatichin shlomimatichin

Labels
enhancement New feature or request good first issue Good for newcomers P3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added -rename=false cli flag shlomimatichin/terratag
3 participants
@shlomimatichin @roni-frantchi @yaronya