added -rename=false cli flag #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlomimatichin
force-pushed
the
no_rename
branch
from
53f0880
to
572b239
Compare
There was a problem hiding this comment.
Looking good @shlomimatichin .
Added a couple of comments.
Also let's update the readme on this one.
| args.Dir = setFlag("dir", ".") | ||
| args.IsSkipTerratagFiles = booleanFlag("skipTerratagFiles", true) | ||
| args.Verbose = booleanFlag("verbose", false) | ||
| args.Rename = booleanFlag("rename", true) |
There was a problem hiding this comment.
I'd change this flag to be overwrite and default to false
There was a problem hiding this comment.
imho overwrite boolean is a confusing term. overwrite true makes sense. but in false, i would expect the file not to change, but currently it disappears, and two other files appear in it's place... so i'm not in love with rename but i would avoid overwrite, at least in my association of the term, it's confusing.
|
@roni-frantchi @shlomimatichin can we merge this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #52
resolves #30