Added -verbose=true cli flag #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this regarding issue #60 |
There was a problem hiding this comment.
@shlomimatichin looks very good to me.
Do have one minor comment - address at your discretion.
Other than that, we should probably update the readme with that flag.
Comment on lines
+29
to
+37
| filter := &logutils.LevelFilter{ | ||
| Levels: []logutils.LogLevel{"DEBUG", "TRACE", "INFO", "WARN", "ERROR"}, | ||
| MinLevel: logutils.LogLevel("INFO"), | ||
| Writer: os.Stderr, | ||
| } | ||
| if args.Verbose { | ||
| filter.MinLevel = logutils.LogLevel("DEBUG") | ||
| } | ||
| log.SetOutput(filter) |
There was a problem hiding this comment.
Perhaps we should extract these to a named function -
- It'd give a header to what's being done
- Perhaps that function would be where we set the log level for tfschema
There was a problem hiding this comment.
+1. will do post merge, since #62 continues where this pull request ends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added -verbose=true cli flag, [DEBUG] messages off by default
Note that tfschema RPC clients still bypass this filter, since each creates a logger itself... submitting a patch to tfschema to request this changed.
resolves #60