Only build against supported versions of ruby. 2.3 + #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsyweb
suggested changes
Jan 29, 2019
There was a problem hiding this comment.
Can we please update the Gem metadata to specify the required Ruby version? E.g:
spec.required_ruby_version = '~> 2.0'We should also include a changelog to be clear that we're dropping support for this version (which should come as no surprise to anyone).
joesustaric
commented
Jan 29, 2019
| @@ -16,6 +16,8 @@ Gem::Specification.new do |gem| | |||
| gem.version = Zxcvbn::VERSION | |||
| gem.license = 'MIT' | |||
|
|
|||
| gem.required_ruby_version = '~> 2.3' | |||
There was a problem hiding this comment.
@johnsyweb - so I picked 2.3 do you think thats ok? or should it be 2.0?
There was a problem hiding this comment.
ah just read your full comment.. yeah a change log would be a great idea for this.. I'll pop it in here as well. Thanks!
|
Updated @johnsyweb |
brushbox
approved these changes
Mar 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build was failing as some older versions of ruby seemed to have issues.
This PR is to update the build to test against 2.3 2.4 2.5 2.6 ruby versions.