Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build against supported versions of ruby. 2.3 + #25

Merged
merged 3 commits into from
May 14, 2019
Merged

Only build against supported versions of ruby. 2.3 + #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e156c7a
adding in supported ruby versions (2.3 +)
Jan 29, 2019
61c3ffa
2.3 min version
Jan 29, 2019
55cd69f
adding in a changelog
Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,12 @@ before_install:
- gem install bundler
language: ruby
rvm:
- '1.9'
- '2.0'
- '2.1'
- '2.2'
- '2.3.0'
- '2.3'
- '2.4'
- '2.5'
- '2.6'
- ruby-head
matrix:
allow_failures:
- rvm: ruby-head
fast_finish: true

9 changes: 9 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Changelog
All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Removed
- This gem will no longer run on Ruby versions < 2.3
2 changes: 2 additions & 0 deletions zxcvbn-ruby.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ Gem::Specification.new do |gem|
gem.version = Zxcvbn::VERSION
gem.license = 'MIT'

gem.required_ruby_version = '~> 2.3'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsyweb - so I picked 2.3 do you think thats ok? or should it be 2.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah just read your full comment.. yeah a change log would be a great idea for this.. I'll pop it in here as well. Thanks!


gem.add_development_dependency 'therubyracer'
gem.add_development_dependency 'rspec'
end