Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Test with GitHub Actions #34

Merged
merged 4 commits into from
Jan 4, 2021
Merged

CI/Test with GitHub Actions #34

merged 4 commits into from
Jan 4, 2021

Conversation

johnsyweb
Copy link
Contributor

@johnsyweb johnsyweb commented Jan 4, 2021

Context

With wait times getting longer on our previous CI provider, we have decided to use GitHub Actions for our open-source projects.

Change

  • Defined CI/Test action in .github/workflows/ci.yml and updated badge.
  • Updated CHANGELOG
  • Use HEAD commit in URIs to make it easier to change default branch name

@johnsyweb johnsyweb requested review from identity-dev-bot and stevehodgkiss and removed request for identity-dev-bot January 4, 2021 22:41
Copy link
Member

@orien orien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

@lucascaton lucascaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johnsyweb johnsyweb merged commit 8e0e9ea into master Jan 4, 2021
@johnsyweb johnsyweb deleted the paj/github-actions branch January 4, 2021 22:57

`zxcvbn-ruby` uses MIT license, the same as [zxcvbn.js][zxcvbn.js] itself. See
[`LICENSE.txt`](https://github.com/envato/zxcvbn-ruby/blob/master/LICENSE.txt)
[`LICENSE.txt`](https://github.com/envato/zxcvbn-ruby/blob/HEAD/LICENSE.txt)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevehodgkiss: I'd like to rename the default branch to main but I don't seem to have permissions to do so on this repository. Is this something you can do, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsyweb sorry I can't help - I don't have admin on the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants