Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/Test with GitHub Actions #34

Merged
merged 4 commits into from
Jan 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: CI

on: [push, pull_request]

jobs:
test:
strategy:
fail-fast: false
matrix:
ruby: ['2.5', '2.6', '2.7', '3.0']
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v2
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
- name: Install dependencies
run: bundle install
- name: Run tests
run: bundle exec rake
13 changes: 0 additions & 13 deletions .travis.yml

This file was deleted.

15 changes: 13 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,19 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Added
- Support for Ruby 3 (thanks [@RSO] ([#32]))

### Changed
- Use [mini\_racer] for running JavaScript specs (thanks [@RSO] ([#33]))
- Moved CI to GitHub Actions ([#34])

[Unreleased]: https://github.com/envato/zxcvbn-ruby/compare/v1.1.0...HEAD
[@rso]: https://github.com/RSO
[mini\_racer]: https://rubygems.org/gems/mini_racer/
[#32]: https://github.com/envato/zxcvbn-ruby/pull/32
[#33]: https://github.com/envato/zxcvbn-ruby/pull/33
[#34]: https://github.com/envato/zxcvbn-ruby/pull/34

## [1.1.0] - 2020-07-16
### Added
Expand All @@ -21,8 +32,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Invalid user dictionaries are handled more robustly ([#28])

[1.1.0]: https://github.com/envato/zxcvbn-ruby/compare/v1.0.0...v1.1.0
[28]: https://github.com/envato/zxcvbn-ruby/pull/28
[29]: https://github.com/envato/zxcvbn-ruby/pull/29
[#28]: https://github.com/envato/zxcvbn-ruby/pull/28
[#29]: https://github.com/envato/zxcvbn-ruby/pull/29

## [1.0.0] - 2019-05-14
### Added
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

This is a Ruby port of Dropbox's [zxcvbn.js][zxcvbn.js] JavaScript library.

## Development status [![Build Status](https://travis-ci.org/envato/zxcvbn-ruby.svg?branch=master)](https://travis-ci.org/envato/zxcvbn-ruby)
## Development status [![CI Status](https://github.com/envato/zxcvbn-ruby/workflows/CI/badge.svg)](https://github.com/envato/zxcvbn-ruby/actions?query=workflow%3ACI)

`zxcvbn-ruby` is considered stable and is used in projects around [Envato][envato].

Expand Down Expand Up @@ -137,16 +137,16 @@ attacker. For this reason we advise you not to store the results of
- [Matthieu Aussaguel](https://github.com/matthieua)
- [_et al._](https://github.com/envato/zxcvbn-ruby/graphs/contributors)

## License [![license](https://img.shields.io/github/license/mashape/apistatus.svg?style=flat-square)](https://github.com/envato/zxcvbn-ruby/blob/master/LICENSE.txt)
## License [![license](https://img.shields.io/github/license/mashape/apistatus.svg?style=flat-square)](https://github.com/envato/zxcvbn-ruby/blob/HEAD/LICENSE.txt)

`zxcvbn-ruby` uses MIT license, the same as [zxcvbn.js][zxcvbn.js] itself. See
[`LICENSE.txt`](https://github.com/envato/zxcvbn-ruby/blob/master/LICENSE.txt)
[`LICENSE.txt`](https://github.com/envato/zxcvbn-ruby/blob/HEAD/LICENSE.txt)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevehodgkiss: I'd like to rename the default branch to main but I don't seem to have permissions to do so on this repository. Is this something you can do, please?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnsyweb sorry I can't help - I don't have admin on the repo

for details.

## Code of Conduct

We welcome contribution from everyone. Read more about it in
[`CODE_OF_CONDUCT.md`](https://github.com/envato/zxcvbn-ruby/blob/master/CODE_OF_CONDUCT.md).
[`CODE_OF_CONDUCT.md`](https://github.com/envato/zxcvbn-ruby/blob/HEAD/CODE_OF_CONDUCT.md).

## Contributing [![PRs welcome](https://img.shields.io/badge/PRs-welcome-orange.svg?style=flat-square)](https://github.com/envato/zxcvbn-ruby/issues)

Expand Down
12 changes: 7 additions & 5 deletions zxcvbn-ruby.gemspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# -*- encoding: utf-8 -*-
require File.expand_path('../lib/zxcvbn/version', __FILE__)

GITHUB_URL = 'https://github.com/envato/zxcvbn-ruby'

Gem::Specification.new do |gem|
gem.authors = ["Steve Hodgkiss", "Matthieu Aussaguel"]
gem.email = ["steve@hodgkiss.me", "matthieu.aussaguel@gmail.com"]
Expand All @@ -22,10 +24,10 @@ Gem::Specification.new do |gem|
gem.add_development_dependency 'rspec'

gem.metadata = {
"bug_tracker_uri" => "https://github.com/envato/zxcvbn-ruby/issues",
"changelog_uri" => "https://github.com/envato/zxcvbn-ruby/blob/master/CHANGELOG.md",
"documentation_uri" => "https://github.com/envato/zxcvbn-ruby/blob/master/README.md",
"homepage_uri" => "https://github.com/envato/zxcvbn-ruby",
"source_code_uri" => "https://github.com/envato/zxcvbn-ruby"
'bug_tracker_uri' => "#{GITHUB_URL}/issues",
'changelog_uri' => "#{GITHUB_URL}/blob/HEAD/CHANGELOG.md",
'documentation_uri' => "#{GITHUB_URL}/blob/HEAD/README.md",
'homepage_uri' => GITHUB_URL,
'source_code_uri' => GITHUB_URL
}
end