Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: remove rules_cc references #2211

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

keith
Copy link
Member

@keith keith commented Apr 26, 2022

I'm removing rules_cc from
envoy as well envoyproxy/envoy#19760 so this
mirrors that.

Signed-off-by: Keith Smiley keithbsmiley@gmail.com

@keith keith marked this pull request as ready for review April 26, 2022 16:09
@keith keith enabled auto-merge (rebase) April 26, 2022 16:09
@keith keith force-pushed the ks/bazel-remove-rules_java-and-rules_cc-references branch from c5f8678 to cedda56 Compare April 26, 2022 16:13
snowp
snowp previously approved these changes Apr 26, 2022
Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@keith keith force-pushed the ks/bazel-remove-rules_java-and-rules_cc-references branch 2 times, most recently from 00fddf2 to 2da21c6 Compare April 30, 2022 00:19
@keith keith force-pushed the ks/bazel-remove-rules_java-and-rules_cc-references branch 2 times, most recently from 4b68d18 to a67d28a Compare May 9, 2022 16:14
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
@keith keith force-pushed the ks/bazel-remove-rules_java-and-rules_cc-references branch from a67d28a to 83ea04d Compare July 13, 2022 17:09
@keith keith changed the title bazel: remove rules_java and rules_cc references bazel: remove rules_cc references Jul 13, 2022
@keith
Copy link
Member Author

keith commented Jul 13, 2022

I'm leaving rules_java now since we're relying on a newer version of that repo's toolchain support now

@keith keith requested a review from snowp July 13, 2022 17:10
@keith keith merged commit e5500ce into main Jul 13, 2022
@keith keith deleted the ks/bazel-remove-rules_java-and-rules_cc-references branch July 13, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants