Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift: generate API docs as a DocC archive #2335

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Jun 2, 2022

And include in GitHub release artifacts

Updates rules_swift to pull in bazelbuild/rules_swift#838

When users open the archive, they'll have rich docs they can explore using Xcode's documentation navigator.

When we update to Xcode 13.4, we'll be able to generate HTML docs with this approach and publish to the documentation website. Here's a demo of what that static site looks like: https://envoy-mobile-docc-demo.netlify.app/documentation/envoy/

envoy-mobile-docc.mp4

Risk Level: Low
Testing: Local, CI
Docs Changes: Added
Release Notes: Added

Signed-off-by: JP Simard jp@jpsim.com

jpsim added 2 commits June 2, 2022 11:11
And include in GitHub release artifacts

Updates rules_swift to pull in bazelbuild/rules_swift#838

When users open the archive, they'll have rich docs they can explore
using Xcode's documentation navigator.

When we update to Xcode 13.4, we'll be able to generate HTML docs with
this approach and publish to the documentation website.

Signed-off-by: JP Simard <jp@jpsim.com>
Signed-off-by: JP Simard <jp@jpsim.com>
@jpsim jpsim marked this pull request as ready for review June 2, 2022 16:02
Copy link
Contributor

@goaway goaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic, thank you @jpsim!

Ultimately, it would be great if we could find a way to also publish these to EM's official documentation tree, but this is a great first step.

@jpsim
Copy link
Contributor Author

jpsim commented Jun 2, 2022

Ultimately, it would be great if we could find a way to also publish these to EM's official documentation tree, but this is a great first step.

I completely agree, and this will be possible when we update to Xcode 13.4, tracked in #2100.

@jpsim
Copy link
Contributor Author

jpsim commented Jun 3, 2022

this will be possible when we update to Xcode 13.4, tracked in #2100.

For more context, this is the Xcode 13.4 feature we need for static website hosting: swiftlang/swift-docc#44

@jpsim jpsim merged commit 234b73f into main Jun 3, 2022
@jpsim jpsim deleted the swift-generate-api-docs-as-a-docc-archive branch June 3, 2022 01:15
jpsim added a commit that referenced this pull request Jun 3, 2022
* main:
  release: re-package xcframework zip (#2336)
  swift: generate API docs as a DocC archive (#2335)
  stats: include new metrics in config (#2332)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants