Add Static Hosting Support #44

macdevnet · 2021-11-18T17:39:07Z

Summary

Requirements

Produces a documentation archive that can be hosted on GitHub Pages or other static services
Allows for a custom base path
Easy to integrate in CI to allow for auto-updating documentation hosting solutions
Backwards compatible with Documentation Archives built with Xcode 13
Supports both the transformation of existing documentation archives and emitting compatible archives as part of the convert process (this would be gated behind a flag).

Solution

DocC-Render will ship with two index.html files. One that includes templating syntax (template-index.html) for the required base path replacement, and one that does not (index.html).
docc convert is updated to only include the base index.html file unless the new flag is passed. This will preserve existing behavior.
When docc convert --transform-for-static-hosting is invoked with the new flag and base path replacement is required, the new template-index.html file will be used, the base path swapped, and it will be copied to all necessary locations.
When docc process-archive transform-for-static-hosting is invoked and base path replacement is required, any existing DocC-Render template files will be deleted, and replaced with the one in the Toolchain.
By default, docc will perform in-place transformation of the given documentation archive.
Whendocc process-archive transform-for-static-hosting --output-path <path> is invoked, the given DocCArchive will not be modified. The compatible version will be placed at the given output path.

Dependencies

Static Template Support in Docc-Render
swiftlang/swift-docc-render#24

Testing

Testing will be from the command line. You will need to ensure export DOCC_HTML_DIR="<path to DocC-Render dist>" is using a dist folder from a version of DocC-Render that produces an index-template.html file.

A suitable test DocC-Render Template is attached to the PR

Tests

Run docc convert and check a archive is still produced correctly
Run docc convert --tranform-for-static-hosting and check the correct folder structure is created and the folders contain the a valid index.html
docc convert --tranform-for-static-hosting --static-hosting-base-path <some value> and check the correct folder structure is created and the folders contain the a valid index.htmlwhich has been transformed with the base path.
Run docc Process-Archive transform-for-static-hosting <path to archive> against a clean .doccarchive and test the output is the same as in test 2.
Run docc Process-Archive transform-for-static-hosting <path to archive> --static-hosting-base-path <some value> against a clean .doccarchive and test the output is the same as in test 3.
Run docc Process-Archive transform-for-static-hosting <path to archive> --outputPath <folder that not exist> against a clean .doccarchive and test new folder is created and the output is correct (data , images, all folders from HTML Template, documentation, tutorials)
Run docc process-archive transform-for-static-hosting <path to archive> --outputPath <existing folder> against a clean .doccarchive test folder icontents have been replaced and the output is correct (data , images, all folders from HTML Template, documentation, tutorials) (repeat with an existing folder that contains hidden files and ensure the hidden files were not replaced)
Run both tests 6 and 7 but add the --static-hosting-base-path <some value> parameter and check the index files have been appropriately amended.
Push the out from Test 8 to git hub and check documentation.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

[ x] Added tests
[ x] Ran the ./bin/test script and it succeeded
[ x] Updated documentation if necessary

dist.zip

rdar://70800606

ethan-kusters · 2021-11-19T19:54:49Z

@macdevnet I tested this out with the experimental custom header/footer support that we use for DocC's docs and realized we forgot to take that into account. @mportiz08 put that together originally so he has more context here.

I put together a proposed implementation here: ethan-kusters@119770f.

But I think we could take that as a follow-up PR since the header/footer support is still experimental. If you'd like to resolve it here that's fine by me as well.

jackhl · 2021-11-20T10:16:44Z

Sources/SwiftDocCUtilities/Action/Actions/Convert/ConvertAction.swift

@@ -330,13 +352,20 @@ public struct ConvertAction: Action, RecreatingContext {
            allProblems.append(contentsOf: indexerProblems)
        }

+        // Process Static Hosting is needed.


Suggested change

// Process Static Hosting is needed.

// Process Static Hosting as needed.

jackhl · 2021-11-20T10:26:06Z

Sources/SwiftDocCUtilities/Action/Actions/Convert/ConvertAction.swift

@@ -330,13 +352,20 @@ public struct ConvertAction: Action, RecreatingContext {
            allProblems.append(contentsOf: indexerProblems)
        }

+        // Process Static Hosting is needed.
+        if transformForStaticHosting, let templateDirectory = htmlTemplateDirectory {
+            let dataProvider = try LocalFileSystemDataProvider(rootURL: temporaryFolder.appendingPathComponent("data"))


We're now constructing the data directory by hand in several different places (temporaryFolder.appendingPathComponent("data")), it'd be nice if there was a constant or computed property or something more centralized so this string and path manipulation wasn't replicated.

jackhl · 2021-11-20T10:30:18Z

Sources/SwiftDocCUtilities/Action/Actions/TransformForStaticHostingAction.swift

+        self.diagnosticEngine.add(DiagnosticConsoleWriter(formattingOptions: []))
+    }
+
+    /// Converts each eligable file from the source archive,


Suggested change

/// Converts each eligable file from the source archive,

/// Converts each eligible file from the source archive and

jackhl · 2021-11-20T10:30:54Z

Sources/SwiftDocCUtilities/Action/Actions/TransformForStaticHostingAction.swift

+    }
+
+    /// Converts each eligable file from the source archive,
+    /// saves the results in the given output  folder.


Suggested change

/// saves the results in the given output folder.

/// saves the results in the given output folder.

jackhl · 2021-11-20T10:32:57Z

Sources/SwiftDocCUtilities/Action/Actions/TransformForStaticHostingAction.swift

+            try setupOutputDirectory(outputURL: outputURL)
+
+            // Copy the appropriate folders from the archive.
+            // We will do it item as we want to preserve anything intentionally left in the output URL by `setupOutputDirectory`


Not sure I follow this second sentence, especially the "We will do it item as we want" part.

jackhl · 2021-11-20T10:35:36Z

Sources/SwiftDocCUtilities/Action/Actions/TransformForStaticHostingAction.swift

+        }
+
+        // Create a StaticHostableTransformer targeted at the archive data folder
+        let dataProvider = try LocalFileSystemDataProvider(rootURL: rootURL.appendingPathComponent("data"))


Another place where the data directory is constructed.

jackhl · 2021-11-20T11:11:07Z

Sources/SwiftDocCUtilities/Transformers/StaticHostableTransformer.swift

+        let htmlOutputURL = directoryRoot.appendingPathComponent(newDirectory)
+        try createDirectory(url: htmlOutputURL)
+
+        // Process the direcorty contents


Suggested change

// Process the direcorty contents

// Process the directory contents

jackhl · 2021-11-20T11:14:20Z

Sources/SwiftDocCUtilities/Transformers/StaticHostableTransformer.swift

+    ///   - directory: The relative path (to the root) of the directory for which then content will processed.
+    ///   - nodes: The directory contents
+    /// - Returns: An array of problems that may have occured during processing
+    private func processDirectoryContents(directoryRoot: URL, relativeSubPath: String, directoryContents: [FSNode]) throws {


For my own understanding, what are these process methods doing, exactly? Is there a way to encapsulate this traversal behavior so it's easier to understand and more testable? For example, if these methods are used to crawl a directory and do something with each file, perhaps it'd be worth creating a type that just knows how to walk FS nodes and e.g. invoke a transformation closure or something on each file.

jackhl · 2021-11-20T11:14:52Z

Sources/SwiftDocCUtilities/Transformers/StaticHostableTransformer.swift

+    ///   - dir: The FSNode that represents the directory
+    ///   - currentDirectory: The relative path (to the root) of the directory that will contain this directory
+    /// - Returns: An array of problems that may have occured during processing
+    private func processDirectory(directoryRoot: URL, currentDirectoryNode: FSNode.Directory, directorySubPath: String) throws {


Again, not really clear what this method is doing because it's just called "process".

jackhl · 2021-11-20T11:16:05Z

Sources/SwiftDocCUtilities/Transformers/StaticHostableTransformer.swift

+        if !newDirectory.isEmpty {
+            newDirectory += "/"
+        }
+        newDirectory += newPathComponent


Any sort of string concatenation of paths raises alarm bells for me. I'm not 100% clear on what this method is doing, but could it use URLComponents or appendingPathComponent?

jackhl · 2021-11-20T11:18:34Z

Tests/SwiftDocCUtilitiesTests/ConvertActionStaticHostableTests.swift

+@testable import SwiftDocCUtilities
+
+class ConvertActionStaticHostableTests: StaticHostingBaseTests {
+    /// Creates a DocC archive and then archive woth options  to produce static content which is then validated.


Suggested change

/// Creates a DocC archive and then archive woth options to produce static content which is then validated.

/// Creates a DocC archive and then archives it with options to produce static content which is then validated.

franklinsch · 2021-12-08T14:50:29Z

Sources/SwiftDocCUtilities/Action/Actions/Convert/ConvertAction.swift

+        let templateURL: URL = temporaryFolder.appendingPathComponent(HTMLTemplate.templateFileName.rawValue)
+        if fileManager.fileExists(atPath: templateURL.path) {
+            // If the `transformForStaticHosting` is not set but there is a `hostingBasePath`
+            // then transform the index template


I'm not sure I understand this behavior. Why are we modifying the index.html if transformForStaticHosting is not set?

We still transform the template if hostingBasePath has been set to allow the non static version of the archive to be hosted somewhere other than root.

This change was based on some feedback we got from Konrad in the forums: https://forums.swift.org/t/support-hosting-docc-archives-in-static-hosting-environments/53572/7.

The hosting-base-path parameter isn't specific to the transform-for-static-hosting work we're doing so it makes sense to support it here as well.

ethan-kusters · 2021-12-09T05:23:50Z

@swift-ci please test

ethan-kusters · 2021-12-09T20:18:41Z

@swift-ci please test

`includesDirectoriesPostOrder` is not available on Linux.

ethan-kusters · 2021-12-09T20:40:40Z

@swift-ci please test

ethan-kusters · 2021-12-09T22:44:51Z

@swift-ci please test

ethan-kusters · 2021-12-09T23:08:43Z

Hi @jackhl! Thank you for all the great feedback here. I think we've addressed the majority of your points but I'd like to leave the pieces that require a larger refactor for a future PR. Definitely work that we should do, but I don't think it should block landing this now since the core pieces are here.

I've filed SR-15575 to track addressing the remaining feedback in a future PR.

ethan-kusters · 2021-12-09T23:09:03Z

Additionally, I've filed SR-15576 to track improving this implementation to support DocC's experimental header/footer support. Since transform-for-static-hosting is still experimental, this lack of support should not block landing the initial implementation but it should be fixed for user's who want to host their docs in a static environment and take advantage of the experimental custom header/footer support.

ethan-kusters

Thank you @macdevnet for all your great work here! Really excited to land this. 🥳

Relevant forums discussion: https://forums.swift.org/t/support-hosting-docc-archives-in-static-hosting-environments/53572. Resolves rdar://70800606. Co-authored-by: Ethan Kusters <ekusters@apple.com>

* Add Static Hosting Support (#44) Relevant forums discussion: https://forums.swift.org/t/support-hosting-docc-archives-in-static-hosting-environments/53572. Resolves rdar://70800606. Co-authored-by: Ethan Kusters <ekusters@apple.com> * Sort output to avoid relying on the undefined order of directory content (#57) Co-authored-by: Steve Scott (Scotty) <macdevnet@users.noreply.github.com> Co-authored-by: David Rönnqvist <ronnqvist@apple.com>

Updates swift-markdown to include: commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (swiftlang#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array. commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204 Author: Franklin Schrans <fschrans@apple.com> Date: Wed Mar 23 14:38:18 2022 +0100 Remove extraneous print in test (swiftlang#33) commit e50693584310a9190071c96c839485b6f2376832 Author: Ethan Kusters <ekusters@apple.com> Date: Mon Mar 21 10:42:02 2022 -0700 Publish Swift Markdown's documentation to GitHub pages (swiftlang#32) * Adopt the Swift-DocC Plugin for documentation generation * Add a script for publishing docs to GitHub pages * Add missing license headers * Move README docs to articles in the DocC catalog * Remove out-of-date documentation about `DiagnosticEngine` Swift markdown no longer includes a DiagnosticEngine so these links were failing to resolve. commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0 Author: christopherweems <github@christopherweems.com> Date: Sat Mar 19 12:53:31 2022 -0400 Fix typo in documentation for `MarkupVisitor` (swiftlang#26) Co-authored-by: Christopher Weems <hello@christopherweems.com>

Updates swift-markdown to include: commit 5fc007220571bf194930a98edeab7133156ab01c Author: Ethan Kusters <ekusters@apple.com> Date: Sat May 21 12:20:47 2022 -0700 Correctly set `indexInParent` in `Markup.child(at:)` This fixes a recent regression where `Markup.child(at:)` began returning markup with incorrect metadata resulting in out-of-bounds errors. The `indexInParent` value of a child is unrelated to the parent's `indexInParent`. This was missed initially because tests were only checking for children of the first item where `indexInParent` would be 0. A new test has been added that asserts `Markup.child(at:)` returns correct values for children of nested items as well. commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (swiftlang#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array. commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204 Author: Franklin Schrans <fschrans@apple.com> Date: Wed Mar 23 14:38:18 2022 +0100 Remove extraneous print in test (swiftlang#33) commit e50693584310a9190071c96c839485b6f2376832 Author: Ethan Kusters <ekusters@apple.com> Date: Mon Mar 21 10:42:02 2022 -0700 Publish Swift Markdown's documentation to GitHub pages (swiftlang#32) * Adopt the Swift-DocC Plugin for documentation generation * Add a script for publishing docs to GitHub pages * Add missing license headers * Move README docs to articles in the DocC catalog * Remove out-of-date documentation about `DiagnosticEngine` Swift markdown no longer includes a DiagnosticEngine so these links were failing to resolve. commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0 Author: christopherweems <github@christopherweems.com> Date: Sat Mar 19 12:53:31 2022 -0400 Fix typo in documentation for `MarkupVisitor` (swiftlang#26) Co-authored-by: Christopher Weems <hello@christopherweems.com>

Updates swift-markdown to include: commit 97df6e2812adcf8698204ca5f0756563ef36e5c1 Author: Ethan Kusters <ekusters@apple.com> Date: Sat May 21 14:02:22 2022 -0700 Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45) This fixes a recent regression where `Markup.child(at:)` began returning markup with incorrect metadata resulting in out-of-bounds errors. The `indexInParent` value of a child is unrelated to the parent's `indexInParent`. This was missed initially because tests were only checking for children of the first item where `indexInParent` would be 0. A new test has been added that asserts `Markup.child(at:)` returns correct values for children of nested items as well. commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (swiftlang#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array. commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204 Author: Franklin Schrans <fschrans@apple.com> Date: Wed Mar 23 14:38:18 2022 +0100 Remove extraneous print in test (swiftlang#33) commit e50693584310a9190071c96c839485b6f2376832 Author: Ethan Kusters <ekusters@apple.com> Date: Mon Mar 21 10:42:02 2022 -0700 Publish Swift Markdown's documentation to GitHub pages (swiftlang#32) * Adopt the Swift-DocC Plugin for documentation generation * Add a script for publishing docs to GitHub pages * Add missing license headers * Move README docs to articles in the DocC catalog * Remove out-of-date documentation about `DiagnosticEngine` Swift markdown no longer includes a DiagnosticEngine so these links were failing to resolve. commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0 Author: christopherweems <github@christopherweems.com> Date: Sat Mar 19 12:53:31 2022 -0400 Fix typo in documentation for `MarkupVisitor` (swiftlang#26) Co-authored-by: Christopher Weems <hello@christopherweems.com>

Updates swift-markdown to include: commit 97df6e2812adcf8698204ca5f0756563ef36e5c1 Author: Ethan Kusters <ekusters@apple.com> Date: Sat May 21 14:02:22 2022 -0700 Correctly set `indexInParent` in `Markup.child(at:)` (#45) This fixes a recent regression where `Markup.child(at:)` began returning markup with incorrect metadata resulting in out-of-bounds errors. The `indexInParent` value of a child is unrelated to the parent's `indexInParent`. This was missed initially because tests were only checking for children of the first item where `indexInParent` would be 0. A new test has been added that asserts `Markup.child(at:)` returns correct values for children of nested items as well. commit 7a7c59d1160fddd23e2379ec5ee8c71df7fd0b3b Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array. commit 36cf89e36e94b025dbe37d82fe2a7da3f39d4204 Author: Franklin Schrans <fschrans@apple.com> Date: Wed Mar 23 14:38:18 2022 +0100 Remove extraneous print in test (#33) commit e50693584310a9190071c96c839485b6f2376832 Author: Ethan Kusters <ekusters@apple.com> Date: Mon Mar 21 10:42:02 2022 -0700 Publish Swift Markdown's documentation to GitHub pages (#32) * Adopt the Swift-DocC Plugin for documentation generation * Add a script for publishing docs to GitHub pages * Add missing license headers * Move README docs to articles in the DocC catalog * Remove out-of-date documentation about `DiagnosticEngine` Swift markdown no longer includes a DiagnosticEngine so these links were failing to resolve. commit 5f10cfb030f43222a49ea34857ff07f02f1e38b0 Author: christopherweems <github@christopherweems.com> Date: Sat Mar 19 12:53:31 2022 -0400 Fix typo in documentation for `MarkupVisitor` (#26) Co-authored-by: Christopher Weems <hello@christopherweems.com>

Includes the following changes: commit 7e704622ef98b3cc9233283b6298ed61806ddb43 Author: Ethan Kusters <ekusters@apple.com> Date: Sat May 21 14:02:22 2022 -0700 Correctly set `indexInParent` in `Markup.child(at:)` (swiftlang#45) This fixes a recent regression where `Markup.child(at:)` began returning markup with incorrect metadata resulting in out-of-bounds errors. The `indexInParent` value of a child is unrelated to the parent's `indexInParent`. This was missed initially because tests were only checking for children of the first item where `indexInParent` would be 0. A new test has been added that asserts `Markup.child(at:)` returns correct values for children of nested items as well. commit 5cc5656732244237066214bc976570f67cfe47b7 Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (swiftlang#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array.

Includes the following changes: commit 7e704622ef98b3cc9233283b6298ed61806ddb43 Author: Ethan Kusters <ekusters@apple.com> Date: Sat May 21 14:02:22 2022 -0700 Correctly set `indexInParent` in `Markup.child(at:)` (#45) This fixes a recent regression where `Markup.child(at:)` began returning markup with incorrect metadata resulting in out-of-bounds errors. The `indexInParent` value of a child is unrelated to the parent's `indexInParent`. This was missed initially because tests were only checking for children of the first item where `indexInParent` would be 0. A new test has been added that asserts `Markup.child(at:)` returns correct values for children of nested items as well. commit 5cc5656732244237066214bc976570f67cfe47b7 Author: Ethan Kusters <ekusters@apple.com> Date: Fri May 20 18:53:24 2022 -0700 Improve performance of `Markup.child(at:)` method (#44) Improves the performance of `Markup.child(at:)` by refactoring to removing the need to iterate over all previous elements in the child array.

Add Static Hosting Support

5d4a4ea

rdar://70800606

dobromir-hristov mentioned this pull request Nov 18, 2021

Add static-hostable support, by allowing changing the baseUrl at runtime swiftlang/swift-docc-render#24

Merged

3 tasks

ethan-kusters requested review from franklinsch, d-ronnqvist and ethan-kusters and removed request for franklinsch and d-ronnqvist November 18, 2021 17:40

d-ronnqvist mentioned this pull request Nov 19, 2021

Adapt tests to work better in Swift CI #45

Merged

3 tasks

jackhl reviewed Nov 20, 2021

View reviewed changes

Fixes for PR#44

2bc5a86

franklinsch reviewed Dec 8, 2021

View reviewed changes

Merge branch 'main' into Add-Static-Hosting-Support

8a5d6cd

Merge branch 'main' into Add-Static-Hosting-Support

dfe24b4

Fix test failures on linux

9b054eb

`includesDirectoriesPostOrder` is not available on Linux.

ethan-kusters added 3 commits December 9, 2021 14:28

Make TemplateOption error messsages more consistent

2d3b228

Make 'StaticHostableTransformer' a struct

60120e4

Merge branch 'main' into Add-Static-Hosting-Support

6087d4f

ethan-kusters approved these changes Dec 9, 2021

View reviewed changes

ethan-kusters merged commit 4ee8b3a into swiftlang:main Dec 9, 2021

ethan-kusters mentioned this pull request Dec 10, 2021

[5.6] Add Static Hosting Support #56

Merged

andrewchang-bird mentioned this pull request Jan 7, 2022

[2/x] Migrate to DocC for API reference docs typealiased/mockingbird#257

Merged

ethan-kusters mentioned this pull request May 3, 2022

[SR-15575] [Swift-DocC] Further refine transform-for-static-hosting implementation based on PR feedback #197

Open

jpsim mentioned this pull request Jun 3, 2022

swift: generate API docs as a DocC archive envoyproxy/envoy-mobile#2335

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Static Hosting Support #44

Add Static Hosting Support #44

macdevnet commented Nov 18, 2021 •

edited

Loading

ethan-kusters commented Nov 19, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

jackhl Nov 20, 2021

franklinsch Dec 8, 2021

macdevnet Dec 8, 2021

ethan-kusters Dec 8, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters left a comment

	// Process Static Hosting is needed.
	// Process Static Hosting as needed.

	/// Converts each eligable file from the source archive,
	/// Converts each eligible file from the source archive and

	/// saves the results in the given output folder.
	/// saves the results in the given output folder.

	// Process the direcorty contents
	// Process the directory contents

	/// Creates a DocC archive and then archive woth options to produce static content which is then validated.
	/// Creates a DocC archive and then archives it with options to produce static content which is then validated.

Add Static Hosting Support #44

Add Static Hosting Support #44

Conversation

macdevnet commented Nov 18, 2021 • edited Loading

Summary

Requirements

Solution

Dependencies

Testing

Checklist

ethan-kusters commented Nov 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters commented Dec 9, 2021

ethan-kusters left a comment

Choose a reason for hiding this comment

macdevnet commented Nov 18, 2021 •

edited

Loading