Skip to content

Commit

Permalink
Windows: untag passing tests (#11741)
Browse files Browse the repository at this point in the history
Risk Level: Low
Testing: Enables tests to run on Windows in CI

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Co-authored-by: William A Rowe Jr <wrowe@vmware.com>
  • Loading branch information
sunjayBhatia and wrowe authored Jul 6, 2020
1 parent 2499ba4 commit f483845
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 17 deletions.
1 change: 0 additions & 1 deletion test/common/network/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ envoy_cc_test(
envoy_cc_test(
name = "addr_family_aware_socket_option_impl_test",
srcs = ["addr_family_aware_socket_option_impl_test.cc"],
tags = ["fails_on_windows"],
deps = [
":socket_option_test",
"//source/common/network:addr_family_aware_socket_option_lib",
Expand Down
1 change: 0 additions & 1 deletion test/common/router/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ envoy_cc_test(
name = "router_upstream_log_test",
srcs = ["router_upstream_log_test.cc"],
external_deps = ["abseil_optional"],
tags = ["fails_on_windows"],
deps = [
"//source/common/buffer:buffer_lib",
"//source/common/network:utility_lib",
Expand Down
2 changes: 0 additions & 2 deletions test/common/upstream/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ envoy_benchmark_test(
envoy_cc_test(
name = "health_checker_impl_test",
srcs = ["health_checker_impl_test.cc"],
tags = ["fails_on_windows"],
deps = [
":utility_lib",
"//source/common/buffer:buffer_lib",
Expand Down Expand Up @@ -399,7 +398,6 @@ envoy_benchmark_test(
name = "load_balancer_benchmark_test",
timeout = "long",
benchmark_binary = "load_balancer_benchmark",
tags = ["fails_on_windows"],
)

envoy_cc_test(
Expand Down
1 change: 0 additions & 1 deletion test/extensions/common/aws/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ envoy_cc_test(
srcs = [
"aws_metadata_fetcher_integration_test.cc",
],
tags = ["fails_on_windows"],
deps = [
"//source/common/common:fmt_lib",
"//source/extensions/common/aws:utility_lib",
Expand Down
1 change: 0 additions & 1 deletion test/extensions/filters/http/cors/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ envoy_extension_cc_test(
name = "cors_filter_integration_test",
srcs = ["cors_filter_integration_test.cc"],
extension_name = "envoy.filters.http.cors",
tags = ["fails_on_windows"],
deps = [
"//source/common/buffer:buffer_lib",
"//source/common/http:header_map_lib",
Expand Down
1 change: 0 additions & 1 deletion test/extensions/filters/http/router/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ envoy_extension_cc_test(
"//test/config/integration/certs",
],
extension_name = "envoy.filters.http.router",
tags = ["fails_on_windows"],
deps = [
"//source/extensions/filters/http/router:config",
"//test/integration:http_integration_lib",
Expand Down
1 change: 0 additions & 1 deletion test/extensions/filters/network/rbac/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ envoy_extension_cc_test(
name = "integration_test",
srcs = ["integration_test.cc"],
extension_name = "envoy.filters.network.rbac",
tags = ["fails_on_windows"],
deps = [
"//source/extensions/filters/network/echo:config",
"//source/extensions/filters/network/rbac:config",
Expand Down
1 change: 0 additions & 1 deletion test/extensions/transport_sockets/alts/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ envoy_extension_cc_test(
"grpc_alts_handshaker_proto",
"grpc_alts_transport_security_common_proto",
],
tags = ["fails_on_windows"],
deps = [
"//source/common/common:utility_lib",
"//source/common/event:dispatcher_includes",
Expand Down
9 changes: 1 addition & 8 deletions test/integration/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ envoy_cc_test(
envoy_cc_test(
name = "cluster_filter_integration_test",
srcs = ["cluster_filter_integration_test.cc"],
tags = ["fails_on_windows"],
deps = [
":integration_lib",
"//include/envoy/network:filter_interface",
Expand All @@ -200,7 +199,6 @@ envoy_cc_test(
envoy_cc_test(
name = "custom_cluster_integration_test",
srcs = ["custom_cluster_integration_test.cc"],
tags = ["fails_on_windows"],
deps = [
":http_integration_lib",
"//source/common/upstream:load_balancer_lib",
Expand Down Expand Up @@ -376,7 +374,6 @@ envoy_cc_test(
data = [
"//test/config/integration/certs",
],
tags = ["fails_on_windows"],
deps = [
":http_integration_lib",
"//source/extensions/transport_sockets/tls:context_lib",
Expand All @@ -393,7 +390,6 @@ envoy_cc_test(
srcs = [
"header_casing_integration_test.cc",
],
tags = ["fails_on_windows"],
deps = [
":http_integration_lib",
"@envoy_api//envoy/config/bootstrap/v3:pkg_cc_proto",
Expand Down Expand Up @@ -748,7 +744,6 @@ envoy_cc_test(
# The symbol table cluster memory tests take a while to run specially under tsan.
# Shard it to avoid test timeout.
shard_count = 2,
tags = ["fails_on_windows"],
deps = [
":integration_lib",
"//source/common/memory:stats_lib",
Expand Down Expand Up @@ -947,7 +942,6 @@ envoy_cc_test(
data = [
"//test/config/integration/certs",
],
tags = ["fails_on_windows"],
deps = [
":integration_lib",
"//source/common/config:api_version_lib",
Expand Down Expand Up @@ -994,7 +988,6 @@ envoy_cc_test(
srcs = [
"tcp_conn_pool_integration_test.cc",
],
tags = ["fails_on_windows"],
deps = [
":integration_lib",
"//include/envoy/server:filter_config_interface",
Expand Down Expand Up @@ -1046,6 +1039,7 @@ envoy_cc_test(
name = "dynamic_validation_integration_test",
srcs = ["dynamic_validation_integration_test.cc"],
data = ["//test/config/integration:server_xds_files"],
# Fails on windows with cr/lf yaml file checkouts
tags = ["fails_on_windows"],
deps = [
":http_integration_lib",
Expand Down Expand Up @@ -1088,7 +1082,6 @@ envoy_cc_test(
data = [
"//test/config/integration/certs",
],
tags = ["fails_on_windows"],
deps = [
":http_integration_lib",
"//source/common/http:header_map_lib",
Expand Down
1 change: 1 addition & 0 deletions test/server/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ envoy_cc_test(
":server_test_data",
":static_validation_test_data",
],
# Fails on windows with cr/lf yaml file checkouts
tags = ["fails_on_windows"],
deps = [
"//source/common/common:version_lib",
Expand Down

0 comments on commit f483845

Please sign in to comment.