Windows: untag passing tests #11741
Merged
Windows: untag passing tests #11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
changed the title
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
…ng-tests Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
…ng-tests Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
…ng-tests Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
…ng-tests Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
…ng-tests Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
sunjayBhatia
requested review from
alyssawilk,
htuch,
mattklein123 and
snowp
as code owners
|
Hey folks, windows CI has been really flaky since this landed. After some discussion amongst the maintainers, I think we're going to roll this back until you folks have root caused the timeouts we have been seeing. Again I'm happy to help out over on #11904, or you can ping me on slack when you have some logs for me to look at. |
alyssawilk
added a commit
to alyssawilk/envoy
that referenced
this pull request
Jul 8, 2020
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
added a commit
that referenced
this pull request
Jul 8, 2020
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Risk Level: Low Testing: Enables tests to run on Windows in CI Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com> Co-authored-by: William A Rowe Jr <wrowe@vmware.com> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
scheler
pushed a commit
to scheler/envoy
that referenced
this pull request
Aug 4, 2020
Rolling back flaky test tagging to help the windows build stay green. Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Windows: untag passing tests
Additional Description:
Risk Level: Low
Testing: Enables tests to run on Windows in CI
Docs Changes: N/A
Release Notes: N/A