Windows: Deprecate moonjit support #13541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
@htuch we can glue this all back together however you like, I wasn't going to deal with merge breakage to master this morning. Just watching the Windows CI result specifically. Whether you want to deprecate moonjit in this PR is your call, or I will cherry pick that into a new PR. |
moderation
reviewed
Oct 13, 2020
See #13539 Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
wrowe
changed the title
|
Holding on merge of #13474 /wait |
|
cc @envoyproxy/windows-dev just FYI No reason to hold off. The windows port makes no reference to toggling moonjit. This patch simply drops all workarounds per the cited issue 13539 to make the residual patch much simpler, between now and decommissioning moonjit support altogether. Converting this to a ready state, since it has no overlap with the current bump to luajit #13474 |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 17, 2020
* master: (22 commits) delay health checks until transport socket secrets are ready. (envoyproxy#13516) test, oauth2: Make sure config test runs field validation (envoyproxy#13496) [http] swap codec implementations to default new (envoyproxy#13579) wasm: update proxy-wasm-cpp-host (envoyproxy#13606) postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393) configs: Update configs v2 -> v3 (envoyproxy#13562) http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546) dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571) listener: add match all filter chain (envoyproxy#13449) fix mistakes in docstrings (envoyproxy#13603) ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269) cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) ext_authz: Avoid calling check multiple times (envoyproxy#13288) docs: Unexclude remaining configs from validation (envoyproxy#13534) build: update rules_rust to allow Rustc in RBE (envoyproxy#13595) docs: Update sphinxext.rediraffe (envoyproxy#13589) Deprecate moonjit support on Windows before beta (envoyproxy#13541) dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474) docs: add TLS stats to cluster stats doc (envoyproxy#13561) ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Windows: Deprecate moonjit support
Additional Description:
See #13539
This is not the entire resolution of the issue, only a simplification
Risk Level: low
Testing: minimal
Docs Changes: n/a here (see c711935)
Release Notes: n/a here (see c711935)