Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add TLS stats to cluster stats doc #13561

Merged
merged 6 commits into from
Oct 15, 2020

Conversation

numerodix
Copy link
Contributor

Commit Message: docs: add TLS stats to cluster stats doc
Risk Level: low
Testing: n/a
Docs Changes: yes
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Martin Matusiak numerodix@gmail.com

Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
Signed-off-by: Martin Matusiak <numerodix@gmail.com>
@numerodix
Copy link
Contributor Author

Hi @ggreenway ,

Not having much luck with the CI at the moment, but the idea with this one is that the ssl. collection of stats also appears on the cluster and this wasn't documented before. To avoid maintaining the same list in two places I've extracted it into a separate file. Hope that looks okay to you.

Copy link
Contributor

@ggreenway ggreenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the docs!

@ggreenway
Copy link
Contributor

@numerodix I'll try to figure out CI. May need to merge master eventually, but I don't think the fix for this CI failure is merged yet. I'll ping here if I need you to do that.

@htuch htuch merged commit c5997de into envoyproxy:master Oct 15, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 17, 2020
* master: (22 commits)
  delay health checks until transport socket secrets are ready. (envoyproxy#13516)
  test, oauth2: Make sure config test runs field validation (envoyproxy#13496)
  [http] swap codec implementations to default new (envoyproxy#13579)
  wasm: update proxy-wasm-cpp-host (envoyproxy#13606)
  postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393)
  configs: Update configs v2 -> v3 (envoyproxy#13562)
  http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546)
  dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571)
  listener: add match all filter chain (envoyproxy#13449)
  fix mistakes in docstrings (envoyproxy#13603)
  ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269)
  cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783)
  ext_authz: Avoid calling check multiple times (envoyproxy#13288)
  docs: Unexclude remaining configs from validation (envoyproxy#13534)
  build: update rules_rust to allow Rustc in RBE (envoyproxy#13595)
  docs: Update sphinxext.rediraffe (envoyproxy#13589)
  Deprecate moonjit support on Windows before beta (envoyproxy#13541)
  dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474)
  docs: add TLS stats to cluster stats doc (envoyproxy#13561)
  ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants