wasm: clear route cache when modifying HTTP request headers. #14318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proxy-Wasm ABI v0.1.0 has a dedicated call for clearing route cache (proxy_clear_route_cache). Proxy-Wasm ABI v0.2.0 removed it in favor of automatically clearing route cache, but that part was never implemented in Envoy. Partially fixes proxy-wasm/spec#16. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
mathetake
previously approved these changes
Dec 8, 2020
There is really no good reason for removing the support for Proxy-Wasm ABI v0.1.0. The extra code is minimal, it's always tested via Rust SDK, and we don't have deprecation policy written down anywhere. It also serves as a good test for support for multiple versions of the ABI. On the other hand, if we really want to remove it, then we should do it before the next Envoy release, so that Proxy-Wasm ABI v0.1.0 is never shipped in a released version of Envoy. |
|
I meant the future when we remove v0.0.1 after having deprecation policy 👍 |
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
mathetake
approved these changes
Dec 15, 2020
lizan
approved these changes
Dec 15, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 16, 2020
* master: (49 commits) sds: allow multiple init managers share sds target (envoyproxy#14357) [http] Remove legacy codecs (envoyproxy#14381) http2: Add integration tests for METADATA and RST_STREAM frame flood mitigation for upstream servers (envoyproxy#14365) test: start dissolving :printers_include rule. (envoyproxy#14429) integration tests: re-enable set_node_on_first_message_only (envoyproxy#14270) formatter: add a formatter that returns a google::protobuf::Struct rather than a string (envoyproxy#14258) ratelimit: support returning custom response bodies for non-OK responses from the external ratelimit service (envoyproxy#14189) deps: update protobuf to 3.14 (envoyproxy#14253) stream_info: add setResponseCode and update local_reply to take a normal StreamInfo (envoyproxy#14402) http: alpn upstream (envoyproxy#13922) Moved starttls integration test to test/extensions/transport_sockets/starttls. (envoyproxy#14425) generic conn pool: directly use thread local cluster (envoyproxy#14423) wasm: add mathetake to CODEOWNERS (envoyproxy#14427) wasm: clear route cache when modifying HTTP request headers. (envoyproxy#14318) tls: disable TLS inspector injection (envoyproxy#14404) aggregate cluster: cleanups (envoyproxy#14411) Mark starttls_integration_test flaky on Windows (envoyproxy#14419) tcp: improved unit testing (envoyproxy#14415) config: making protocol config explicit (envoyproxy#14362) wasm: dead code (envoyproxy#14407) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proxy-Wasm ABI v0.1.0 has a dedicated call for clearing route cache
(proxy_clear_route_cache).
Proxy-Wasm ABI v0.2.0 removed it in favor of automatically clearing
route cache, but that part was never implemented in Envoy.
Partially fixes proxy-wasm/spec#16.
Signed-off-by: Piotr Sikora piotrsikora@google.com