stream_info: add setResponseCode and update local_reply to take a normal StreamInfo #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mal StreamInfo Signed-off-by: John Esmet <john.esmet@gmail.com>
esmet
commented
Dec 14, 2020
| /** | ||
| * @param code the HTTP response code to set for this request. | ||
| */ | ||
| virtual void setResponseCode(uint32_t code) PURE; |
There was a problem hiding this comment.
The callers of this function pass in Http::Code but the underlying type is uint32_t, so I went with that.
Open to suggestions as to whether we think this should remain uint32_t or change to Http::Code.
|
LG overall - want to take a look at CI and ping back? |
Yes it looks like I missed updating a test. Will do shortly and ping back. |
alyssawilk
approved these changes
Dec 15, 2020
|
Pushed the fix and CI looks 💚 |
alyssawilk
approved these changes
Dec 15, 2020
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Dec 16, 2020
* master: (49 commits) sds: allow multiple init managers share sds target (envoyproxy#14357) [http] Remove legacy codecs (envoyproxy#14381) http2: Add integration tests for METADATA and RST_STREAM frame flood mitigation for upstream servers (envoyproxy#14365) test: start dissolving :printers_include rule. (envoyproxy#14429) integration tests: re-enable set_node_on_first_message_only (envoyproxy#14270) formatter: add a formatter that returns a google::protobuf::Struct rather than a string (envoyproxy#14258) ratelimit: support returning custom response bodies for non-OK responses from the external ratelimit service (envoyproxy#14189) deps: update protobuf to 3.14 (envoyproxy#14253) stream_info: add setResponseCode and update local_reply to take a normal StreamInfo (envoyproxy#14402) http: alpn upstream (envoyproxy#13922) Moved starttls integration test to test/extensions/transport_sockets/starttls. (envoyproxy#14425) generic conn pool: directly use thread local cluster (envoyproxy#14423) wasm: add mathetake to CODEOWNERS (envoyproxy#14427) wasm: clear route cache when modifying HTTP request headers. (envoyproxy#14318) tls: disable TLS inspector injection (envoyproxy#14404) aggregate cluster: cleanups (envoyproxy#14411) Mark starttls_integration_test flaky on Windows (envoyproxy#14419) tcp: improved unit testing (envoyproxy#14415) config: making protocol config explicit (envoyproxy#14362) wasm: dead code (envoyproxy#14407) ... Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: stream_info: add setResponseCode and update local_reply to take a normal StreamInfo
Additional Description: This makes local_reply a little cleaner by removing a small implementation detail and adding a new setter function to StreamInfo.
Risk Level: medium (refactors existing code)
Testing: No new tests
Docs Changes: None
Release Notes: None