Add OTLP proto dependencies #14471
Closed
Add OTLP proto dependencies #14471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repokitteh-read-only
bot
added
the
deps
|
envoyproxy/dependency-shepherds cannot be assigned as a reviewer to this issue. |
|
/assign yanavlasov |
|
The dependency itself looks OK but do we want to bring this into the project without the code to use it? |
I just thought I'd split it, but I'll convert this to a draft until PR #14469 is in and I'll add the code that uses this dependency. Thanks! |
|
Looks like master merge was not right. |
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Temporary commit Small fixes Signed-off-by: Itamar Kaminski <itamark@google.com> Testing skeleton Signed-off-by: Itamar Kaminski <itamark@google.com> Test skeleton Signed-off-by: Itamar Kaminski <itamark@google.com> Tests and Access logger cache generalization Signed-off-by: Itamar Kaminski <itamark@google.com> Tests done Signed-off-by: Itamar Kaminski <itamark@google.com> Tests done after horrible merge Signed-off-by: Itamar Kaminski <itamark@google.com> Uncomment something Signed-off-by: Itamar Kaminski <itamark@google.com> Cleanups and dependency fixes Signed-off-by: Itamar Kaminski <itamark@google.com> Format fix Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Signed-off-by: Itamar Kaminski <itamark@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itamar Kaminski itamark@google.com
Commit Message: Add a dependency on OTLP protos.
Additional Description: This will be used as part of the OTLP logger
Risk Level: Low (only adding a dependency)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]