Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix misplaced #[extension-category] for Wasm runtimes #17078

Merged
merged 4 commits into from
Jun 23, 2021
Merged

doc: fix misplaced #[extension-category] for Wasm runtimes #17078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
938c52d
doc: remove misplaced #[extension-category] for wasm runtimes
mathetake Jun 22, 2021
50e8cd8
Put #extension-categoy in the right place.
mathetake Jun 22, 2021
16f1678
Fix proto format
mathetake Jun 22, 2021
2175b3a
put right above runtime
mathetake Jun 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/envoy/extensions/wasm/v3/wasm.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ message VmConfig {
// **envoy.wasm.runtime.wasmtime**: `Wasmtime <https://wasmtime.dev/>`_-based WebAssembly runtime.
// This runtime is not enabled in the official build.
//
// [#extension-category: envoy.wasm.runtime]
string runtime = 2 [(validate.rules).string = {min_len: 1}];

// The Wasm code that Envoy will execute.
Expand All @@ -86,7 +87,6 @@ message VmConfig {
// (proxy_on_start). `google.protobuf.Struct` is serialized as JSON before
// passing it to the plugin. `google.protobuf.BytesValue` and
// `google.protobuf.StringValue` are passed directly without the wrapper.
// [#extension-category: envoy.wasm.runtime]
mathetake marked this conversation as resolved.
Show resolved Hide resolved
google.protobuf.Any configuration = 4;

// Allow the wasm file to include pre-compiled code on VMs which support it.
Expand Down
2 changes: 1 addition & 1 deletion generated_api_shadow/envoy/extensions/wasm/v3/wasm.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.