doc: fix misplaced #[extension-category] for Wasm runtimes #17078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
phlax
reviewed
Jun 22, 2021
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
force-pushed
the
wasm-runtime-extensions
branch
from
c918ce7 to
50e8cd8
Compare
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
@phlax PTAL! |
mathetake
changed the title
mathetake
changed the title
mathetake
changed the title
phlax
requested changes
Jun 23, 2021
There was a problem hiding this comment.
@mathetake im not clear exactly where the ext-cat annotation should go - but it wants to be associated with a field - so directly above it - i guess its the runtime field if its not the configuration
i notice that you have left the existing listing - im happy with that for now - not sure how we can handle this better
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
|
cc @htuch @adisuissa for api props |
|
/lgtm api |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jun 23, 2021
…bridge-stream * upstream/main: (268 commits) tools: adding dio,better comments (envoyproxy#17104) doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078) ci: Speedup deps precheck (envoyproxy#17102) doc: fix wrong link on wasm network filter. (envoyproxy#17079) docs: Added v3 API reference. (envoyproxy#17095) docs: Update include paths in repo (envoyproxy#17098) exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122) tools: adding reminders for API shephards (envoyproxy#17081) ci: Fix wasm verify example (envoyproxy#17086) [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671) test: silencing flaky test (envoyproxy#17084) Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816) Listener: reset the file event when destroying listener filters (envoyproxy#16952) docs: link additional filters that emit dynamic metadata (envoyproxy#17059) rds: add config reload time stat for rds (envoyproxy#17033) bazel: Use color by default for build and run commands (envoyproxy#17077) ci: Add timing for docker pull (envoyproxy#17074) [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058) quic: add quic version counters in http3 codec stats. (envoyproxy#16943) quiche: change crypto stream factory interfaces (envoyproxy#17046) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
…y#17078) Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…y#17078) Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#extension-category: envoy.wasm.runtime]was misplaced onconfigurationfield, so this PR puts in the right place (runtimefield).