Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link additional filters that emit dynamic metadata #17059

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jun 21, 2021

Commit Message:

docs: link additional filters that emit dynamic metadata

Additional Description: N/A
Risk Level: N/A
Testing: Manually build docs and verified link targets
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: James Peach <jpeach@apache.org>
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but would be good to get a stamp from other maintainer

i guess my main question would be if this is now all of the extensions that emit dynamic metadata ?

@phlax phlax removed their assignment Jun 22, 2021
@alyssawilk alyssawilk self-assigned this Jun 22, 2021
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@phlax to your point it may not be all, but it's more accurate so I think it's a win to merge.

@alyssawilk alyssawilk merged commit 0af6284 into envoyproxy:main Jun 22, 2021
@jpeach
Copy link
Contributor Author

jpeach commented Jun 22, 2021 via email

baojr added a commit to baojr/envoy that referenced this pull request Jun 23, 2021
…bridge-stream

* upstream/main: (268 commits)
  tools: adding dio,better comments (envoyproxy#17104)
  doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078)
  ci: Speedup deps precheck (envoyproxy#17102)
  doc: fix wrong link on wasm network filter. (envoyproxy#17079)
  docs: Added v3 API reference. (envoyproxy#17095)
  docs: Update include paths in repo (envoyproxy#17098)
  exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122)
  tools: adding reminders for API shephards (envoyproxy#17081)
  ci: Fix wasm verify example (envoyproxy#17086)
  [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671)
  test: silencing flaky test (envoyproxy#17084)
  Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816)
  Listener: reset the file event when destroying listener filters (envoyproxy#16952)
  docs: link additional filters that emit dynamic metadata (envoyproxy#17059)
  rds: add config reload time stat for rds (envoyproxy#17033)
  bazel: Use color by default for build and run commands (envoyproxy#17077)
  ci: Add timing for docker pull (envoyproxy#17074)
  [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058)
  quic: add quic version counters in http3 codec stats. (envoyproxy#16943)
  quiche: change crypto stream factory interfaces (envoyproxy#17046)
  ...

Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
…17059)

docs: link additional filters that emit dynamic metadata

Additional Description: N/A
Risk Level: N/A
Testing: Manually build docs and verified link targets
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: James Peach <jpeach@apache.org>
Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
…17059)

docs: link additional filters that emit dynamic metadata

Additional Description: N/A
Risk Level: N/A
Testing: Manually build docs and verified link targets
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: James Peach <jpeach@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants