Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of PR #17087 (To Remove include ) #17098

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

ankatare
Copy link
Contributor

Signed-off-by: Abhay Narayan Katare abhay.katare@india.nec.com

Commit Message: removing some more include from docs.
Additional Description: Extension of work. original PR #17087
Risk Level: LOW
Testing: Yes
Docs Changes: Yes
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
@phlax
Copy link
Member

phlax commented Jun 23, 2021

@ankatare why not just include this in #17087 ?

@ankatare
Copy link
Contributor Author

@phlax some issues in my local branch and also changes were bit more so pushed in different PR. is that Okay ?

@phlax
Copy link
Member

phlax commented Jun 23, 2021

is that Okay ?

i guess - but i think it would be easier for people reviewing any changes to have these together

@ankatare
Copy link
Contributor Author

@phlax humm. i agree. i linked both PRs for visibility , please review this time. will tc.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks @ankatare

iiuc this PR contains all of the fixes - so will #17087 close now ?

@ankatare
Copy link
Contributor Author

@phlax yes, please close

@ankatare
Copy link
Contributor Author

thanks for your help on this and quick review @phlax

@phlax phlax merged commit ae49453 into envoyproxy:main Jun 23, 2021
baojr added a commit to baojr/envoy that referenced this pull request Jun 23, 2021
…bridge-stream

* upstream/main: (268 commits)
  tools: adding dio,better comments (envoyproxy#17104)
  doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078)
  ci: Speedup deps precheck (envoyproxy#17102)
  doc: fix wrong link on wasm network filter. (envoyproxy#17079)
  docs: Added v3 API reference. (envoyproxy#17095)
  docs: Update include paths in repo (envoyproxy#17098)
  exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122)
  tools: adding reminders for API shephards (envoyproxy#17081)
  ci: Fix wasm verify example (envoyproxy#17086)
  [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671)
  test: silencing flaky test (envoyproxy#17084)
  Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816)
  Listener: reset the file event when destroying listener filters (envoyproxy#16952)
  docs: link additional filters that emit dynamic metadata (envoyproxy#17059)
  rds: add config reload time stat for rds (envoyproxy#17033)
  bazel: Use color by default for build and run commands (envoyproxy#17077)
  ci: Add timing for docker pull (envoyproxy#17074)
  [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058)
  quic: add quic version counters in http3 codec stats. (envoyproxy#16943)
  quiche: change crypto stream factory interfaces (envoyproxy#17046)
  ...

Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo pushed a commit to chrisxrepo/envoy that referenced this pull request Jul 8, 2021
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Signed-off-by: chris.xin <xinchuantao@qq.com>
@ankatare ankatare deleted the reference_glitch_some_more branch September 29, 2021 11:11
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants