rds: add config reload time stat for rds #17033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
ramaraochavali
commented
Jun 18, 2021
| @@ -53,6 +53,7 @@ The following statistics are generated for all subscriptions. | |||
| :widths: 1, 1, 2 | |||
|
|
|||
| config_reload, Counter, Total API fetches that resulted in a config reload due to a different config | |||
| config_reload_time, Gauge, Timestamp of the last config reload as milliseconds since the epoch | |||
There was a problem hiding this comment.
config_reload is only applicable/implemented for RDS/SRDS and VHDS - but added here generically. I followed the same pattern and added this new stat here even though it is implemented only for RDS and SRDS. If it is better to move to rds stats page - I can move.
There was a problem hiding this comment.
can you name this stat config_reload_time_ms?
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
jmarantz
reviewed
Jun 18, 2021
| @@ -53,6 +53,7 @@ The following statistics are generated for all subscriptions. | |||
| :widths: 1, 1, 2 | |||
|
|
|||
| config_reload, Counter, Total API fetches that resulted in a config reload due to a different config | |||
| config_reload_time, Gauge, Timestamp of the last config reload as milliseconds since the epoch | |||
There was a problem hiding this comment.
can you name this stat config_reload_time_ms?
test/common/router/rds_impl_test.cc
Outdated
| @@ -290,6 +290,10 @@ TEST_F(RdsImplTest, Basic) { | |||
| // Old config use count should be 1 now. | |||
| EXPECT_EQ(1, config.use_count()); | |||
| EXPECT_EQ(2UL, scope_.counter("foo.rds.foo_route_config.config_reload").value()); | |||
| EXPECT_NE(0, scope_ | |||
There was a problem hiding this comment.
could this flake if the test runs in <1ms?
If you are just trying to ensure that the gauge exists, you can use findGaugeByString, which is on class TestStore, which is the base class of MockIsolatedStatsStore.
There was a problem hiding this comment.
Sure.. Will change to ensure gauge exists.
|
@jmarantz PTAL addressed comments. The coverage failure not seems relevant. |
jmarantz
previously approved these changes
Jun 21, 2021
source/common/router/rds_impl.h
Outdated
| COUNTER(config_reload) \ | ||
| GAUGE(config_reload_time_ms, NeverImport) \ |
There was a problem hiding this comment.
nit: sort this block alphabetically, so the 2 counters go together.
source/common/router/scoped_rds.h
Outdated
| @@ -84,6 +84,7 @@ class InlineScopedRoutesConfigProvider : public Envoy::Config::ImmutableConfigPr | |||
| // clang-format off | |||
| #define ALL_SCOPED_RDS_STATS(COUNTER, GAUGE) \ | |||
| COUNTER(config_reload) \ | |||
| GAUGE(config_reload_time_ms, NeverImport) \ | |||
|
@envoyproxy/senior-maintainers assignee is @ggreenway |
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
|
/retest |
|
Retrying Azure Pipelines: |
ggreenway
approved these changes
Jun 21, 2021
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jun 23, 2021
…bridge-stream * upstream/main: (268 commits) tools: adding dio,better comments (envoyproxy#17104) doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078) ci: Speedup deps precheck (envoyproxy#17102) doc: fix wrong link on wasm network filter. (envoyproxy#17079) docs: Added v3 API reference. (envoyproxy#17095) docs: Update include paths in repo (envoyproxy#17098) exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122) tools: adding reminders for API shephards (envoyproxy#17081) ci: Fix wasm verify example (envoyproxy#17086) [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671) test: silencing flaky test (envoyproxy#17084) Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816) Listener: reset the file event when destroying listener filters (envoyproxy#16952) docs: link additional filters that emit dynamic metadata (envoyproxy#17059) rds: add config reload time stat for rds (envoyproxy#17033) bazel: Use color by default for build and run commands (envoyproxy#17077) ci: Add timing for docker pull (envoyproxy#17074) [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058) quic: add quic version counters in http3 codec stats. (envoyproxy#16943) quiche: change crypto stream factory interfaces (envoyproxy#17046) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
Signed-off-by: Rama Chavali <rama.rao@salesforce.com> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
Signed-off-by: Rama Chavali <rama.rao@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to know when a route update is loaded to Envoy. This PR adds a stat to indicate the same.
Commit Message: add config reload time stat.
Additional Description:
Risk Level: Low
Testing: Added
Docs Changes: Updated
Release Notes: Updated
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]