[fuzz]: fix oss fuzz bug 34515, limit maglev table size #16671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 26, 2021 02:59
|
/retest |
|
Retrying Azure Pipelines: |
asraa
reviewed
May 27, 2021
lizan
reviewed
May 27, 2021
| @@ -412,8 +412,8 @@ message Cluster { | |||
| // The table size for Maglev hashing. The Maglev aims for ‘minimal disruption’ rather than an absolute guarantee. | |||
| // Minimal disruption means that when the set of upstreams changes, a connection will likely be sent to the same | |||
| // upstream as it was before. Increasing the table size reduces the amount of disruption. | |||
| // The table size must be prime number. If it is not specified, the default is 65537. | |||
| google.protobuf.UInt64Value table_size = 1; | |||
| // The table size must be prime number limited to 4M. If it is not specified, the default is 65537. | |||
There was a problem hiding this comment.
5M? the constraints below doesn't match comment here.
There was a problem hiding this comment.
just a random prime number larger than 4M, nothing special here.
There was a problem hiding this comment.
Since we publish this documentation separately from the proto source, it should contain the actual, exact limit.
Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
|
/restest |
|
/retest |
|
Retrying Azure Pipelines: |
lizan
approved these changes
Jun 22, 2021
|
/retest |
|
Retrying Azure Pipelines: |
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Jun 23, 2021
…bridge-stream * upstream/main: (268 commits) tools: adding dio,better comments (envoyproxy#17104) doc: fix misplaced #[extension-category] for Wasm runtimes (envoyproxy#17078) ci: Speedup deps precheck (envoyproxy#17102) doc: fix wrong link on wasm network filter. (envoyproxy#17079) docs: Added v3 API reference. (envoyproxy#17095) docs: Update include paths in repo (envoyproxy#17098) exception: make Ipv6Instance and Ipv4Instance not throw and remove some try catch pattern (envoyproxy#16122) tools: adding reminders for API shephards (envoyproxy#17081) ci: Fix wasm verify example (envoyproxy#17086) [fuzz]: fix oss fuzz bug 34515, limit maglev table size (envoyproxy#16671) test: silencing flaky test (envoyproxy#17084) Set `validate` flag when the SAN(SubjectAltName) matching is performed (envoyproxy#16816) Listener: reset the file event when destroying listener filters (envoyproxy#16952) docs: link additional filters that emit dynamic metadata (envoyproxy#17059) rds: add config reload time stat for rds (envoyproxy#17033) bazel: Use color by default for build and run commands (envoyproxy#17077) ci: Add timing for docker pull (envoyproxy#17074) [Windows] Adding note section in Original Source HTTP Filter (envoyproxy#17058) quic: add quic version counters in http3 codec stats. (envoyproxy#16943) quiche: change crypto stream factory interfaces (envoyproxy#17046) ... Signed-off-by: Garrett Bourg <bourg@squareup.com>
chrisxrepo
pushed a commit
to chrisxrepo/envoy
that referenced
this pull request
Jul 8, 2021
…6671) Signed-off-by: chaoqin-li1123 <chaoqinli@google.com> Signed-off-by: chris.xin <xinchuantao@qq.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…6671) Signed-off-by: chaoqin-li1123 <chaoqinli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: In fuzz test, to large a maglev table trigger a vector length exception(https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=34515), fix by setting limit to maglev table size.
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]