Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_proc: send attributes #31090

Merged

Merge branch 'main' into feature/ext_proc/request-response-attributes

cfe7006
Select commit
Loading
Failed to load commit list.
Merged

ext_proc: send attributes #31090

Merge branch 'main' into feature/ext_proc/request-response-attributes
cfe7006
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Envoy/Prechecks succeeded Jan 18, 2024 in 7m 7s

Envoy/Prechecks (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Envoy/Prechecks (pr/31090/main@cfe7006)

Check started by

Request (pr/31090/main@cfe7006)

jbohanon @jbohanon cfe7006 #31090 merge main@f20b6ca

ext_proc: send attributes

Rework of #30781 which was reverted in #31017 due to ASAN fuzzer issues

The ASAN fuzzer issues are unrelated to the net-new code here and will affect any code that calls CEL Parse.

The main differences between this and the original PR:

  • Refactored out expression/mathching code into separate util classes
  • Preserve the expr object from which ParsedExpr are built per #30781 (comment)
  • Conditionally fuzz the request_attributes and response_attributes fields on non-ASAN fuzzing due to unrelated issue with ASAN fuzzing in CEL parsing per #31017 (comment)

Commit Message:
Introduce the ability to send attributes in the External Processing Request
Additional Description:
Risk Level: Low
Testing: Integration tests for request/response attributes

Release Notes: N/A
Platform Specific Features: CEL parsing will not work on Windows

Environment

Request variables

Key Value
ref 9ff7b63f72b87794a9c770876bde9845cf232620
sha cfe7006
pr 31090
base-sha f20b6ca
actor jbohanon @jbohanon
message ext_proc: send attributes...
started 1705612277.299341
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:0ca52447572ee105a4730da5e76fe47c9c5a7c64
mobile envoyproxy/envoy-build-ubuntu:mobile-0ca52447572ee105a4730da5e76fe47c9c5a7c64
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 30
patch 0
dev true