ci: Make the mobile-cc CI job run on all Envoy changes #33162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's important for us to run the mobile C++ unit and integration tests on any Envoy change. If we don't, we run the risk of breaking Envoy Mobile with seemingly benign changes. For example, envoyproxy#32775 caused Envoy Mobile to permafail because an Envoy Mobile unit test wasn't run (see envoyproxy#33158 for the fix). This change ensures that the Envoy Mobile C++ tests run on all core Envoy changes. There aren't too many of these tests, so it shouldn't add much to the runtime of CI per PR. Signed-off-by: Ali Beyad <abeyad@google.com>
phlax
reviewed
Mar 27, 2024
.github/config.yml
Outdated
| - mobile/.bazelrc | ||
| - mobile/**/* | ||
| - tools/code_format/check_format.py | ||
| - "**/*" |
There was a problem hiding this comment.
as discussed offline can we make this a bit more specific - something like
- .bazelrc
- .bazelversion
- .github/config.yml
- bazel/external/quiche.BUILD
- bazel/repository_locations.bzl
- mobile/**/*
- source/**/*
- test/?/*
- envoy/**/*
- api/**/*probably we should update the others that run on everything similarly
There was a problem hiding this comment.
thanks for the suggestion, made the change, let's see how CI does with it
Signed-off-by: Ali Beyad <abeyad@google.com>
phlax
approved these changes
Mar 28, 2024
alyssawilk
pushed a commit
to alyssawilk/envoy
that referenced
this pull request
Apr 29, 2024
) It's important for us to run the mobile C++ unit and integration tests on any Envoy change. If we don't, we run the risk of breaking Envoy Mobile with seemingly benign changes. For example, envoyproxy#32775 caused Envoy Mobile to permafail because an Envoy Mobile unit test wasn't run (see envoyproxy#33158 for the fix). This change ensures that the Envoy Mobile C++ tests run on all core Envoy changes. There aren't too many of these tests, so it shouldn't add much to the runtime of CI per PR. Signed-off-by: Ali Beyad <abeyad@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's important for us to run the mobile C++ unit and integration tests on any Envoy change. If we don't, we run the risk of breaking Envoy Mobile with seemingly benign changes.
For example, #32775 caused Envoy Mobile to permafail because an Envoy Mobile unit test wasn't run (see #33158 for the fix).
This change ensures that the Envoy Mobile C++ tests run on all core Envoy changes. There aren't too many of these tests, so it shouldn't add much to the runtime of CI per PR.