Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Make the mobile-cc CI job run on all Envoy changes #33162

Merged
merged 2 commits into from
Mar 28, 2024
Merged

ci: Make the mobile-cc CI job run on all Envoy changes #33162

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff89c31
ci: Make the mobile-cc CI job run on all Envoy changes
abeyad Mar 27, 2024
6cbaf10
phlax feedback
abeyad Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions .github/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,7 @@ run:
- tools/code_format/check_format.py
mobile-cc:
paths:
- .bazelrc
- .bazelversion
- .github/config.yml
- bazel/external/quiche.BUILD
- bazel/repository_locations.bzl
- mobile/.bazelrc
- mobile/**/*
- tools/code_format/check_format.py
- "**/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline can we make this a bit more specific - something like

    - .bazelrc
    - .bazelversion
    - .github/config.yml
    - bazel/external/quiche.BUILD
    - bazel/repository_locations.bzl
    - mobile/**/*
    - source/**/*
    - test/?/*
    - envoy/**/*
    - api/**/*

probably we should update the others that run on everything similarly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the suggestion, made the change, let's see how CI does with it

mobile-compile-time-cc:
paths:
- "**/*"
Expand Down