Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel: Bump version -> 7.4.0 #37864

Merged
merged 1 commit into from
Jan 3, 2025
Merged

bazel: Bump version -> 7.4.0 #37864

merged 1 commit into from
Jan 3, 2025

Conversation

phlax
Copy link
Member

@phlax phlax commented Jan 3, 2025

the current bazel version is flakey and is triggering at least one build issue for downstreams

the only reason we are using it is due to broken env vars in later versions that fails our mobile/coverage ci

this PR bumps the version to 7.x latest and worksaround the mobile/coverage issue by injecting the known working bazel version for that ci alone

Fix #37857
Fix #37852

Signed-off-by: Ryan Northey <ryan@synca.io>
@@ -58,6 +58,13 @@ jobs:
run: |
cd mobile
tar -czf coverage.tar.gz generated/coverage
# TODO(phlax): This is a highly undesirable workaround - remove once
# https://github.com/bazelbuild/bazel/issues/23247 is resolved/available
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @keith

@phlax
Copy link
Member Author

phlax commented Jan 3, 2025

/retest

@phlax
Copy link
Member Author

phlax commented Jan 3, 2025

@phlax
Copy link
Member Author

phlax commented Jan 3, 2025

also fixes currently failing examples ci

@adisuissa
Copy link
Contributor

Ah, thanks!
FWIW, I've also encountered an issue with oss-fuzz: google/oss-fuzz#12895
The fix was to manually set the version to 7.4.0 (export USE_BAZEL_VERSION=7.4.0).

Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlax
Copy link
Member Author

phlax commented Jan 3, 2025

cool, ill push through as its breaking a lot of stuff

@phlax phlax merged commit a505621 into envoyproxy:main Jan 3, 2025
23 of 24 checks passed
This was referenced Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants