-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: Bump version -> 7.4.0 #37864
bazel: Bump version -> 7.4.0 #37864
Conversation
Signed-off-by: Ryan Northey <ryan@synca.io>
@@ -58,6 +58,13 @@ jobs: | |||
run: | | |||
cd mobile | |||
tar -czf coverage.tar.gz generated/coverage | |||
# TODO(phlax): This is a highly undesirable workaround - remove once | |||
# https://github.com/bazelbuild/bazel/issues/23247 is resolved/available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @keith
/retest |
also fixes currently failing examples ci |
Ah, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cool, ill push through as its breaking a lot of stuff |
the current bazel version is flakey and is triggering at least one build issue for downstreams
the only reason we are using it is due to broken env vars in later versions that fails our mobile/coverage ci
this PR bumps the version to 7.x latest and worksaround the mobile/coverage issue by injecting the known working bazel version for that ci alone
Fix #37857
Fix #37852