redis: command splitting #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyft/network-team @danielhochman please review |
|
|
||
| auto handler = command_map_.find(request.asArray()[0].asString()); | ||
| if (handler == command_map_.end()) { | ||
| callbacks.onResponse(Utility::makeError("unsupported command")); |
There was a problem hiding this comment.
may be include command name to the error msg
RomanDzhabarov
approved these changes
Mar 27, 2017
This commit adds end to end support for incr, incrby, and mget, including full command splitting for mget and proper hashing for single server commands. There is much more work needed (more logging, stats, timeouts, etc.) but the basic flow is working and I am able to proxy to multiple backend redis servers locally.
mattklein123
force-pushed
the
redis_commands
branch
from
ba53fbb to
2176c06
Compare
jplevyak
added a commit
to jplevyak/envoy
that referenced
this pull request
Oct 2, 2020
…nvoyproxy#616) Signed-off-by: John Plevyak <jplevyak@gmail.com>
wolfguoliang
pushed a commit
to wolfguoliang/envoy
that referenced
this pull request
Jan 23, 2021
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: this PR integrates [Envoy's ApiListener](#9516) to replace Envoy Mobile's use of the AsyncClient. Doing so gives Envoy Mobile access to all L7 facilities provided by Envoy's Http Connection Manager; including but no limited to the L7 filters. Risk Level: HIGH! This PR changes the underlying code for Envoy Mobile's core functionality Testing: unit tests updated for the dispatcher, integration tests, and e2e tests with the example apps. Additionally, the ApiListener code has been unit and integration tested in Envoy. Fixes #543 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: this PR integrates [Envoy's ApiListener](#9516) to replace Envoy Mobile's use of the AsyncClient. Doing so gives Envoy Mobile access to all L7 facilities provided by Envoy's Http Connection Manager; including but no limited to the L7 filters. Risk Level: HIGH! This PR changes the underlying code for Envoy Mobile's core functionality Testing: unit tests updated for the dispatcher, integration tests, and e2e tests with the example apps. Additionally, the ApiListener code has been unit and integration tested in Envoy. Fixes #543 Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds end to end support for incr, incrby, and mget,
including full command splitting for mget and proper hashing for
single server commands. There is much more work needed (more logging,
stats, timeouts, etc.) but the basic flow is working and I am able
to proxy to multiple backend redis servers locally.