-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gateway api to v0.6.0-rc2 #816
Conversation
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
hitting kubernetes-sigs/controller-runtime#2035 since k8s was indirectly bumped to 1.26 |
Addresses kubernetes-sigs/controller-runtime#2035 which was fixed with kubernetes-sigs/controller-runtime#2087 and included in v0.14.0 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
bumping controller runtime to v0.14.0 fixes the build issue, seeing tests fail now
|
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@chauhanshubham how were these tests passing before 🙃 |
Codecov Report
@@ Coverage Diff @@
## main #816 +/- ##
==========================================
+ Coverage 64.43% 64.61% +0.18%
==========================================
Files 46 46
Lines 6071 6071
==========================================
+ Hits 3912 3923 +11
+ Misses 1929 1916 -13
- Partials 230 232 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
I guess before the spec bump, not adding |
ah yah adds up, thanks |
Caused by merging envoyproxy#791 without rebasing envoyproxy#816 Signed-off-by: Arko Dasgupta <arko@tetrate.io>
* Fix package import for HTTPRouteFilterExtensionRef Caused by merging #791 without rebasing #816 Signed-off-by: Arko Dasgupta <arko@tetrate.io> * fix test was failing with below error ``` --- FAIL: TestProcessHTTPRoutes/httproute_with_one_authenticationfilter (0.00s) routes_test.go:221: Error Trace: /Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/routes_test.go:221 Error: Received unexpected error: List on GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute specifies selector on field gatewayHTTPRouteIndex, but no index with name gatewayHTTPRouteIndex has been registered for GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute Test: TestProcessHTTPRoutes/httproute_with_one_authenticationfilter ``` Signed-off-by: Arko Dasgupta <arko@tetrate.io> Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta arko@tetrate.io