Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gateway api to v0.6.0-rc2 #816

Merged
merged 5 commits into from
Dec 17, 2022
Merged

bump gateway api to v0.6.0-rc2 #816

merged 5 commits into from
Dec 17, 2022

Conversation

arkodg
Copy link
Contributor

@arkodg arkodg commented Dec 16, 2022

Signed-off-by: Arko Dasgupta arko@tetrate.io

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg arkodg requested a review from a team as a code owner December 16, 2022 18:56
@arkodg
Copy link
Contributor Author

arkodg commented Dec 16, 2022

hitting kubernetes-sigs/controller-runtime#2035 since k8s was indirectly bumped to 1.26

Addresses kubernetes-sigs/controller-runtime#2035
which was fixed with kubernetes-sigs/controller-runtime#2087
and included in v0.14.0

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
Copy link
Contributor Author

arkodg commented Dec 16, 2022

bumping controller runtime to v0.14.0 fixes the build issue, seeing tests fail now

2022-12-16T15:16:18.446-0800	ERROR	kubernetes/predicates.go:82	unable to find associated HTTPRoutes	{"error": "List on GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=Gateway specifies selector on field secretGatewayIndex, but no index with name secretGatewayIndex has been registered for GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=Gateway"}
github.com/envoyproxy/gateway/internal/provider/kubernetes.(*gatewayAPIReconciler).validateSecretForReconcile
	/Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/predicates.go:82
github.com/envoyproxy/gateway/internal/provider/kubernetes.TestValidateSecretForReconcile.func1
	/Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/predicates_test.go:156
testing.tRunner
	/usr/local/opt/go@1.19/libexec/src/testing/testing.go:1446
2022-12-16T15:16:18.446-0800	ERROR	kubernetes/predicates.go:82	unable to find associated HTTPRoutes	{"error": "List on GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=Gateway specifies selector on field secretGatewayIndex, but no index with name secretGatewayIndex has been registered for GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=Gateway"}
github.com/envoyproxy/gateway/internal/provider/kubernetes.(*gatewayAPIReconciler).validateSecretForReconcile
	/Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/predicates.go:82
github.com/envoyproxy/gateway/internal/provider/kubernetes.TestValidateSecretForReconcile.func1
	/Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/predicates_test.go:156
testing.tRunner

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@arkodg
Copy link
Contributor Author

arkodg commented Dec 17, 2022

@chauhanshubham how were these tests passing before 🙃

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2022

Codecov Report

Merging #816 (dbd8724) into main (9cfbacf) will increase coverage by 0.18%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   64.43%   64.61%   +0.18%     
==========================================
  Files          46       46              
  Lines        6071     6071              
==========================================
+ Hits         3912     3923      +11     
+ Misses       1929     1916      -13     
- Partials      230      232       +2     
Impacted Files Coverage Δ
internal/provider/kubernetes/controller.go 53.63% <94.33%> (+1.53%) ⬆️
internal/provider/kubernetes/helpers.go 78.22% <0.00%> (+2.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
@danehans danehans merged commit 679c60b into envoyproxy:main Dec 17, 2022
@arkodg arkodg deleted the bump-gapi branch December 17, 2022 02:27
@chauhanshubham
Copy link
Member

@chauhanshubham how were these tests passing before 🙃

I guess before the spec bump, not adding WithIndex just worked in the fake client, so if there was a query that used an indexed field, it was just returning all objects.

@arkodg
Copy link
Contributor Author

arkodg commented Dec 17, 2022

@chauhanshubham how were these tests passing before 🙃

I guess before the spec bump, not adding WithIndex just worked in the fake client, so if there was a query that used an indexed field, it was just returning all objects.

ah yah adds up, thanks

arkodg added a commit to arkodg/gateway that referenced this pull request Dec 19, 2022
Caused by merging envoyproxy#791
without rebasing envoyproxy#816

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
danehans pushed a commit that referenced this pull request Dec 19, 2022
* Fix package import for HTTPRouteFilterExtensionRef

Caused by merging #791
without rebasing #816

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

* fix test

was failing with below error
```
    --- FAIL: TestProcessHTTPRoutes/httproute_with_one_authenticationfilter (0.00s)
        routes_test.go:221:
            	Error Trace:	/Users/arkodebdasgupta/go-workspace/src/github.com/envoyproxy/gateway/internal/provider/kubernetes/routes_test.go:221
            	Error:      	Received unexpected error:
            	            	List on GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute specifies selector on field gatewayHTTPRouteIndex, but no index with name gatewayHTTPRouteIndex has been registered for GroupVersionKind gateway.networking.k8s.io/v1beta1, Kind=HTTPRoute
            	Test:       	TestProcessHTTPRoutes/httproute_with_one_authenticationfilter
```

Signed-off-by: Arko Dasgupta <arko@tetrate.io>

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants