Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s to 1.26 #2035

Closed
jmrodri opened this issue Nov 1, 2022 · 5 comments · Fixed by #2087
Closed

Bump k8s to 1.26 #2035

jmrodri opened this issue Nov 1, 2022 · 5 comments · Fixed by #2087

Comments

@jmrodri
Copy link
Contributor

jmrodri commented Nov 1, 2022

Creating an issue to ask for the 1.26 bump. https://www.k8s.dev/resources/release/#kubernetes-126

K8S 1.26 GA date is 2002/12/06
@lengrongfu
Copy link

@jmrodri
"K8S 1.26 GA date is 2002/12/06"=>"K8S 1.26 GA date is 2012/12/06"

@chiukapoor
Copy link

@jmrodri @lengrongfu

K8S 1.26 GA date is 2002/12/06

K8S 1.26 GA date is 2022/12/06

@katexochen
Copy link

1.26 is out, and controller-runtime breaks when updating k8s Go dependencies:

❯ go vet ./...
# sigs.k8s.io/controller-runtime/pkg/cache
../../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:144:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
        "k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
                have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
                want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)
../../../../go/pkg/mod/sigs.k8s.io/controller-runtime@v0.13.1/pkg/cache/informer_cache.go:158:9: cannot use i.Informer (variable of type "k8s.io/client-go/tools/cache".SharedIndexInformer) as type Informer in return statement:
        "k8s.io/client-go/tools/cache".SharedIndexInformer does not implement Informer (wrong type for AddEventHandler method)
                have AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler) ("k8s.io/client-go/tools/cache".ResourceEventHandlerRegistration, error)
                want AddEventHandler(handler "k8s.io/client-go/tools/cache".ResourceEventHandler)

@katexochen katexochen mentioned this issue Dec 9, 2022
Merged
1 task
@rturner3 rturner3 mentioned this issue Dec 9, 2022
Merged
@lucacome lucacome mentioned this issue Dec 9, 2022
Merged
This was referenced Dec 9, 2022
Closed
Closed
Closed
Closed
This was referenced Dec 12, 2022
Closed
Closed
Merged
@JohnStrunk JohnStrunk mentioned this issue Dec 12, 2022
Closed
@katmutua katmutua mentioned this issue Dec 13, 2022
Closed
@xor22h
Copy link

xor22h commented Dec 14, 2022

Is there a plan for new version released? as we face same issues as @katexochen

@giorio94 giorio94 mentioned this issue Dec 14, 2022
Closed
1 task
@arkodg arkodg mentioned this issue Dec 16, 2022
Merged
@arkodg
Copy link

arkodg commented Dec 16, 2022

@xor22h the v0.14.0 release has included the k8s 1.26 bump

arkodg added a commit to arkodg/gateway that referenced this issue Dec 16, 2022
@arkodg
bump controller runtime to v0.14.0
caba70b 
Addresses kubernetes-sigs/controller-runtime#2035
which was fixed with kubernetes-sigs/controller-runtime#2087
and included in v0.14.0

Signed-off-by: Arko Dasgupta <arko@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Bump k8s.io deps to v0.26.0 lucacome/controller-runtime
6 participants
@jmrodri @xor22h @arkodg @lengrongfu @chiukapoor @katexochen